Skip to content

Disable automatic votes deletion (issue #52) #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Disable automatic votes deletion (issue #52) #333

wants to merge 3 commits into from

Conversation

@konard
Copy link
Member

@konard konard commented Sep 14, 2025 •
edited
Loading

Summary

  • Implements solution for issue Disable automatic votes deletion #52 to disable automatic votes deletion
  • Adds configurable behavior for collective votes and message deletion
  • Maintains full backward compatibility

Changes Made

  • Added DISABLE_AUTOMATIC_VOTES_DELETION configuration setting (default: True)
  • Modified python/modules/commands.py to conditionally perform deletion operations:
    • Automatic votes clearing after collective vote processing
    • Automatic message deletion in karma-related operations
  • Added test scripts and documentation for verification

Test Plan

  • Added configuration test script to verify setting works correctly
  • Added test documentation explaining the solution
  • Verified conditional logic is applied in all 4 required locations
  • Confirmed backward compatibility by allowing toggle to original behavior

Behavior

When DISABLE_AUTOMATIC_VOTES_DELETION = True (default):

  • Vote messages are NOT automatically deleted
  • Collective votes are NOT automatically cleared after reaching threshold
  • Karma changes still apply normally

When DISABLE_AUTOMATIC_VOTES_DELETION = False:

  • Original behavior is preserved (automatic deletion/clearing)

🤖 Generated with Claude Code

Resolves #52

@konard
Initial commit with task details for issue #52
9d9965f 
Adding CLAUDE.md with task information for AI processing.
This file will be removed when the task is complete.

Issue: #52
@konard konard self-assigned this Sep 14, 2025
@konard @claude
Disable automatic votes deletion (issue #52)
efa0df6 
- Add DISABLE_AUTOMATIC_VOTES_DELETION config option (default: True)
- Prevent automatic clearing of collective votes after processing
- Prevent automatic deletion of vote messages
- Maintain backward compatibility with configurable behavior
- Add test scripts and documentation for verification

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@konard konard changed the title [WIP] Disable automatic votes deletion Disable automatic votes deletion (issue #52) Sep 14, 2025
@konard konard marked this pull request as ready for review September 14, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@konard konard

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disable automatic votes deletion

2 participants

@konard