Add sort by intermediate votes functionality #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #51
- Add calculate_intermediate_votes function to DataBuilder - Add get_users_sorted_by_intermediate_votes function to sort users by pending votes only - Add top_votes command method to Commands class for displaying intermediate vote rankings - Add TOP_VOTES and BOTTOM_VOTES patterns for command recognition - Register new commands in main bot module - Add comprehensive tests for new functionality - Include experiment script to validate intermediate votes calculation This allows users to see rankings based only on pending supporters/opponents votes, separate from actual karma scores, addressing the requested "sort by intermediate votes" feature. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements sorting by intermediate votes functionality to address issue #51.
What is "intermediate votes"?
Intermediate votes refer to pending supporter/opponent votes that haven't yet been converted to actual karma points. In the current system:
Changes Made
New DataBuilder functions:
calculate_intermediate_votes()- calculates pending votes valueget_users_sorted_by_intermediate_votes()- sorts users by intermediate votes onlyNew Commands:
top votes/топ голоса- shows users with highest intermediate votesbottom votes/низ голоса- shows users with lowest intermediate votesPattern Recognition: Added support for Russian and English vote commands
Comprehensive Testing: Added tests and validation scripts
Examples
Technical Details
The intermediate votes calculation is:
supporters/2 - opponents/3Test Results
✅ All existing tests pass
✅ New functionality validated with test script
✅ Properly handles edge cases (no votes, mixed votes)
Test plan
🤖 Generated with Claude Code
Resolves #51