Skip to content

Implement size-based method to distinguish child tree from thread in AVL balanced trees #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implement size-based method to distinguish child tree from thread in AVL balanced trees #498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77e0b1e
Initial commit with task details for issue #86
konard Sep 14, 2025
19433a8
Implement size-based method to distinguish child tree from thread in …
konard Sep 14, 2025
d1546f8
Remove CLAUDE.md - Claude command completed
konard Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions csharp/Platform.Data.Doublets/Memory/United/Generic/LinksAvlBalancedTreeMethodsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,29 @@ protected virtual bool GetLeftIsChildValue(TLinkAddress value)
//return Bit<TLinkAddress>.PartialRead(value != 4, 1, default);
}

/// <summary>
/// <para>
/// Determines whether the left child of a node is a child (not a thread) using size comparison.
/// </para>
/// <para></para>
/// </summary>
/// <param name="node">
/// <para>The node.</para>
/// <para></para>
/// </param>
/// <returns>
/// <para>The bool</para>
/// <para></para>
/// </returns>
[MethodImpl(methodImplOptions: MethodImplOptions.AggressiveInlining)]
protected virtual bool GetLeftIsChildBySizeComparison(TLinkAddress node)
{
var nodeSize = GetSize(node);
var left = GetLeft(node);
var leftSize = GetSizeOrZero(left);
return leftSize > TLinkAddress.Zero && nodeSize > leftSize;
}

/// <summary>
/// <para>
/// Sets the left is child value using the specified stored value.
Expand Down Expand Up @@ -567,6 +590,29 @@ protected virtual bool GetRightIsChildValue(TLinkAddress value)
//return Bit<TLinkAddress>.PartialRead(value != 3, 1, default);
}

/// <summary>
/// <para>
/// Determines whether the right child of a node is a child (not a thread) using size comparison.
/// </para>
/// <para></para>
/// </summary>
/// <param name="node">
/// <para>The node.</para>
/// <para></para>
/// </param>
/// <returns>
/// <para>The bool</para>
/// <para></para>
/// </returns>
[MethodImpl(methodImplOptions: MethodImplOptions.AggressiveInlining)]
protected virtual bool GetRightIsChildBySizeComparison(TLinkAddress node)
{
var nodeSize = GetSize(node);
var right = GetRight(node);
var rightSize = GetSizeOrZero(right);
return rightSize > TLinkAddress.Zero && nodeSize > rightSize;
}

/// <summary>
/// <para>
/// Sets the right is child value using the specified stored value.
Expand Down
8 changes: 4 additions & 4 deletions csharp/Platform.Data.Doublets/Memory/United/Generic/LinksSourcesAvlBalancedTreeMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public LinksSourcesAvlBalancedTreeMethods(LinksConstants<TLinkAddress> constants

/// <summary>
/// <para>
/// Determines whether this instance get left is child.
/// Determines whether this instance get left is child using size comparison.
/// </para>
/// <para></para>
/// </summary>
Expand All @@ -186,7 +186,7 @@ public LinksSourcesAvlBalancedTreeMethods(LinksConstants<TLinkAddress> constants
/// <para></para>
/// </returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected override bool GetLeftIsChild(TLinkAddress node) => GetLeftIsChildValue(GetLinkReference(node).SizeAsSource);
protected override bool GetLeftIsChild(TLinkAddress node) => GetLeftIsChildBySizeComparison(node);

/// <summary>
/// <para>
Expand All @@ -207,7 +207,7 @@ public LinksSourcesAvlBalancedTreeMethods(LinksConstants<TLinkAddress> constants

/// <summary>
/// <para>
/// Determines whether this instance get right is child.
/// Determines whether this instance get right is child using size comparison.
/// </para>
/// <para></para>
/// </summary>
Expand All @@ -220,7 +220,7 @@ public LinksSourcesAvlBalancedTreeMethods(LinksConstants<TLinkAddress> constants
/// <para></para>
/// </returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected override bool GetRightIsChild(TLinkAddress node) => GetRightIsChildValue(GetLinkReference(node).SizeAsSource);
protected override bool GetRightIsChild(TLinkAddress node) => GetRightIsChildBySizeComparison(node);

/// <summary>
/// <para>
Expand Down
8 changes: 4 additions & 4 deletions csharp/Platform.Data.Doublets/Memory/United/Generic/LinksTargetsAvlBalancedTreeMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ public LinksTargetsAvlBalancedTreeMethods(LinksConstants<TLinkAddress> constants

/// <summary>
/// <para>
/// Determines whether this instance get left is child.
/// Determines whether this instance get left is child using size comparison.
/// </para>
/// <para></para>
/// </summary>
Expand All @@ -186,7 +186,7 @@ public LinksTargetsAvlBalancedTreeMethods(LinksConstants<TLinkAddress> constants
/// <para></para>
/// </returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected override bool GetLeftIsChild(TLinkAddress node) => GetLeftIsChildValue(GetLinkReference(node).SizeAsTarget);
protected override bool GetLeftIsChild(TLinkAddress node) => GetLeftIsChildBySizeComparison(node);

/// <summary>
/// <para>
Expand All @@ -207,7 +207,7 @@ public LinksTargetsAvlBalancedTreeMethods(LinksConstants<TLinkAddress> constants

/// <summary>
/// <para>
/// Determines whether this instance get right is child.
/// Determines whether this instance get right is child using size comparison.
/// </para>
/// <para></para>
/// </summary>
Expand All @@ -220,7 +220,7 @@ public LinksTargetsAvlBalancedTreeMethods(LinksConstants<TLinkAddress> constants
/// <para></para>
/// </returns>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
protected override bool GetRightIsChild(TLinkAddress node) => GetRightIsChildValue(GetLinkReference(node).SizeAsTarget);
protected override bool GetRightIsChild(TLinkAddress node) => GetRightIsChildBySizeComparison(node);

/// <summary>
/// <para>
Expand Down
Loading