Firewall settings modules

[zliang-akamai]

📝 Description

This is to add firewall_settings and firewall_settings_info module.

✔️ How to Test

You might need to enable default firewall for your account to test it.

Note that once it's enabled for an account, it cannot be turned off, which means you will have to permanently have a default firewall for each of the resources in you account.

curl --request PUT \
     --url https://api.linode.com/v4beta/networking/firewalls/settings \
     --header 'accept: application/json' \
     --header "authorization: Bearer $TOKEN" \   
     --header 'content-type: application/json' \
     --data '
{
    "default_firewall_ids": { 
        "public_interface": YOUR_DEFAULT_FIREWALL_ID,
        "vpc_interface": YOUR_DEFAULT_FIREWALL_ID,
        "linode": YOUR_DEFAULT_FIREWALL_ID,
        "nodebalancer": YOUR_DEFAULT_FIREWALL_ID
    }                 
}

'

Testing the modules:

make test-int TEST_SUITE=firewall_settings

[lgarber-akamai]

This looks great, nice work!

For the null default_firewall_ids.X issue you mentioned: it looks like the _serialize(...) method is excluding the keys of null fields from FirewallSettingsDefaultFirewallIDs, which is preventing handle_updates(...) from detecting a diff on those keys. Would it make sense to use include_none_values, always_include, or put_class in the class implementation in the Python SDK to address this?

[ezilber-akamai]

LGTM! Tests passing locally.

[zliang-akamai]

Hi @lgarber-akamai, I enabled include_none_values in FirewallSettingsDefaultFirewallIDs in linode/linode_api4-python#558

[lgarber-akamai]

Thank you for addressing my feedback in the Python SDK!