Skip to content

Conversation

@yec-akamai
Copy link
Contributor

📝 Description

Enable ACLP alerts by supporting the following functionalities in linode ansible modules:

  • Alert Definition
  • Alert Channel (only list available currently)

Note: All the listing endpoints only accept simple filters. Listing alert definition by service type can't support any filters currently. Modified base ListModule and add a new configurable field disable_filters to support it.

✔️ How to Test

Integration test:

make test-int TEST_ARGS="-vvvvvv monitor_services_alert_definition"  

@yec-akamai yec-akamai requested a review from a team as a code owner December 11, 2025 20:24
@yec-akamai yec-akamai added the new-feature for new features in the changelog. label Dec 11, 2025
@yec-akamai yec-akamai requested review from Copilot, vshanthe and zliang-akamai and removed request for a team December 11, 2025 20:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables ACLP alerts functionality in Linode Ansible modules by introducing support for alert definitions and alert channels. The implementation includes modules for creating, updating, deleting, and listing alert definitions, as well as listing alert channels. A key technical enhancement is the addition of a disable_filters configuration option to the ListModule base class to accommodate API endpoints that don't support filtering.

  • Adds comprehensive alert definition management with create/update/delete operations and wait functionality
  • Implements specialized listing modules for alert definitions and channels with custom filter logic
  • Extends base ListModule class to support endpoints without filtering capabilities

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
tests/integration/targets/monitor_services_alert_definition/tasks/main.yaml Integration test suite validating CRUD operations and list functionality for alert definitions
plugins/modules/monitor_services_alert_definition.py Main module implementing alert definition lifecycle management with wait conditions
plugins/modules/monitor_services_alert_definition_list.py List module for alert definitions with custom ACLP filter constructor
plugins/modules/monitor_services_alert_definition_info.py Info module for retrieving individual alert definition details
plugins/modules/monitor_services_alert_definition_by_service_type_list.py Specialized list module for filtering alert definitions by service type
plugins/modules/monitor_alert_channel_list.py List module for alert channels with custom filter logic
plugins/module_utils/linode_helper.py Helper function implementing ACLP-specific filter construction logic
plugins/module_utils/linode_common_list.py Enhanced base ListModule with disable_filters configuration option
plugins/module_utils/doc_fragments/*.py Documentation fragments defining examples and sample responses
docs/modules/*.md Generated documentation for all new modules
README.md Updated module listing with new alert-related modules

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 20 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zliang-akamai
Copy link
Member

Everything looks good other than the Copilot comments. Let's get Python SDK released before merge this PR

@yec-akamai yec-akamai added the do-not-merge PRs that should not be merged until the commented issue is resolved label Dec 30, 2025
Copy link
Contributor

@vshanthe vshanthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yec-akamai yec-akamai removed the do-not-merge PRs that should not be merged until the commented issue is resolved label Jan 16, 2026
@yec-akamai yec-akamai merged commit f14ce9f into linode:dev Jan 16, 2026
13 checks passed
@yec-akamai yec-akamai deleted the TPT-4091/aclp-alerts branch January 16, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants