-
Notifications
You must be signed in to change notification settings - Fork 27
Make NodePool optional for LKE-E #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Release v0.41.1
Release v0.42.0
3833092 to
c747097
Compare
5c5c9cd to
dbf4982
Compare
|
Wow!!! This is really happening! I'm exciting to hear that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR makes node pools optional for LKE Enterprise clusters and skips Kubernetes dashboard polling for enterprise tier clusters. The changes enable creating enterprise clusters without node pools while maintaining the requirement that standard clusters must have at least one node pool.
Key Changes:
- Modified node pool handling to allow empty node pools for enterprise clusters while enforcing the requirement for standard clusters
- Added conditional logic to skip dashboard URL polling for enterprise tier clusters
- Added integration test for creating enterprise clusters without node pools
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| plugins/modules/lke_cluster.py | Implements optional node pools for enterprise clusters and skips dashboard polling for enterprise tier |
| tests/integration/targets/lke_cluster_enterprise_no_pools/tasks/main.yaml | Adds integration test to verify enterprise cluster creation without node pools |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…de into optional-nodepools
ezilber-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One small thing - can you add a test case for attempting to create a standard LKE cluster without any node pools to verify that it fails as expected? Also looks like there's a small lint issue to fix. Thanks for the contribution!
ezilber-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/integration/targets/lke_cluster_standard_no_pools/main.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ae4ebce to
42f5200
Compare
42f5200 to
ee62aff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/integration/targets/lke_cluster_standard_no_pools/tasks/main.yaml
Outdated
Show resolved
Hide resolved
ee62aff to
c502f19
Compare
c502f19 to
ec011dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tests/integration/targets/lke_cluster_enterprise_no_pools/tasks/main.yaml
Outdated
Show resolved
Hide resolved
tests/integration/targets/lke_cluster_enterprise_no_pools/tasks/main.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s/main.yaml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
📝 Description
What does this PR do and why is this change necessary?
linode.cloud.lke_clusterfor enterprise clusters✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
LINODE_TOKEN