feat: using coredns for lke-e clusters #2635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merll
approved these changes
Oct 29, 2025
j-zimnowoda
approved these changes
Oct 29, 2025
j-zimnowoda
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
After further investigation we saw that both LKE and LKE-E are using coreDns. Strangely in LKE-E the coreDns app is missing the
k8s-app: kube-dnswhich is supposed to be set by default. The missing label would break the kube-prometheus-stack services since if no selector is provided in the values, it would use the defaultk8s-app: kube-dnsone. This PR fixes that.🔍 Reviewer Notes
🧹 Checklist