Contribute can gateway configuration feature #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A gcov and addresssanitizer are generic source code quality improvement tools. It's a good tool for testing. This patch add enale/disable support for gcov and address-sanitizer.
libsocketcan.c has some common function between libcangw.c. But
that common function is implemented with static.
This patch split out common static function to libsocketcan-utils.c.
Each function remove static from function. In addition, it's
added __attribute__((__visibility__("hidden"))) to avoid symbol export.
This patch create cangw_add_rule and cangw_delete_rule functions. These support to modify CAN gateway configuration one by one.
This patch add test code to test to cangw_add_rule and cangw_delete_rule.
An cangw_clean_rule function is clean up for CAN gateway configuration of all. This patch implement to that clean function.
cangw_get_rules use to getting a all routing rule of the CAN gateway infrastructure. That function allocates memory to save runting informations. cangw_release_rules use to free memory that is allocated by cangw_get_rules. This patch impliment to both function.
This patch add some unit test. It uses CMOCKA library that is unit test framework for C language. In addtion, this patch add some shell scripts that enables interface creation and clean up, clean up in case of test is failed, and create coveradge report.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing libsocketcan has can interface configuration feature. I propose to extend CAN_GW support into lisocketcan.