ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing

[richm]

Ansible 2.20 has deprecated the use of Ansible facts as variables. For
example, ansible_distribution is now deprecated in favor of
ansible_facts["distribution"]. This is due to making the default
setting INJECT_FACTS_AS_VARS=false. For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

In order to ensure that commits and PRs conform to this, use
ANSIBLE_INJECT_FACT_VARS=false by default in our CI testing.

Update README-ostree.md if needed.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Configure CI workflows to run Ansible-based tests with fact injection disabled by default.

CI:

• Set ANSIBLE_INJECT_FACT_VARS=false for qemu-kvm integration test workflow runs.
• Propagate SR_ANSIBLE_INJECT_FACT_VARS=false into the tft workflow environment for Terraform-based tests.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Sets Ansible’s fact injection behavior to use the modern, non-injected facts API during CI by default, aligning tests with upcoming Ansible 2.24 behavior and wiring this through both GitHub Actions and the TFT pipeline.

Sequence diagram for CI running Ansible with ANSIBLE_INJECT_FACT_VARS disabled

sequenceDiagram
    actor Developer
    participant GitHubActions as GitHubActionsWorkflow
    participant TFT as TFT_Test_Framework
    participant Ansible as AnsibleRunner

    Developer->>GitHubActions: Push commit / open PR
    GitHubActions->>GitHubActions: Start CI job
    GitHubActions->>GitHubActions: Set env SR_ANSIBLE_INJECT_FACT_VARS=false
    GitHubActions->>TFT: Invoke TFT with SR_ANSIBLE_INJECT_FACT_VARS=false
    TFT->>Ansible: Run playbooks with ANSIBLE_INJECT_FACT_VARS=false
    Ansible-->>TFT: Execute using ansible_facts access pattern
    TFT-->>GitHubActions: Return test results
    GitHubActions-->>Developer: Report CI status

Loading

File-Level Changes

Change	Details	Files
Configure GitHub Actions qemu-kvm integration tests to run with ANSIBLE_INJECT_FACT_VARS disabled.	Add ANSIBLE_INJECT_FACT_VARS="false" to the job-level env section so all steps in the qemu-kvm integration workflow inherit the setting and use the non-injected facts API during tests.	.github/workflows/qemu-kvm-integration-tests.yml
Propagate the Ansible fact injection setting into the TFT-based test pipeline.	Introduce SR_ANSIBLE_INJECT_FACT_VARS=false in the Terraform/TFT workflow’s vars string so downstream test runner tooling also enforces the non-injected facts behavior.	.github/workflows/tft.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}