ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#230
Merged
ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]#230
Conversation
…s them [citest_skip] tox-lsr 3.17.1 has a fix for the broken container tests There was one shell function for both setting up the callback plugins and the connection plugin. When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not set, so all subsequent tests failed. The connection plugin must be present and the env. var. must be set in order to run any container tests. The code was fixed to ensure that there is always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS is always set and contains this path. Also, setting up the callback plugins and the connection plugin is already idempotent, so no reason to skip them. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates GitHub Actions workflows to use tox-lsr 3.17.1 (which fixes broken container tests) and ensures callback/connection plugin setup is always executed during qemu-kvm integration tests by removing the SKIP_CALLBACK_PLUGINS toggle and a minor shell indentation fix. Sequence diagram for qemu-kvm integration tests with mandatory connection plugin setupsequenceDiagram
actor Developer
participant GitHubActions
participant Workflow_qemu_kvm
participant tox_lsr_3_17_1
participant Setup_connection_and_callback_plugins
participant Ansible_container_tests
Developer->>GitHubActions: Push PR / commit
GitHubActions->>Workflow_qemu_kvm: Trigger qemu-kvm-integration-tests
Workflow_qemu_kvm->>tox_lsr_3_17_1: Install and invoke tox-lsr 3.17.1
tox_lsr_3_17_1->>Setup_connection_and_callback_plugins: Run setup (no skip toggle)
Setup_connection_and_callback_plugins-->>Setup_connection_and_callback_plugins: Ensure connection plugin installed
Setup_connection_and_callback_plugins-->>Setup_connection_and_callback_plugins: Set ANSIBLE_CONNECTION_PLUGINS env var
Setup_connection_and_callback_plugins-->>Setup_connection_and_callback_plugins: Setup callback plugins (idempotent)
Setup_connection_and_callback_plugins-->>tox_lsr_3_17_1: Setup complete
tox_lsr_3_17_1->>Ansible_container_tests: Run container tests using connection plugin
Ansible_container_tests-->>GitHubActions: Report test results
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The tox-lsr version string is duplicated across multiple workflows; consider defining it once (e.g., in a workflow-level env var or reusable workflow) so future version bumps only require a single change.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The tox-lsr version string is duplicated across multiple workflows; consider defining it once (e.g., in a workflow-level env var or reusable workflow) so future version bumps only require a single change.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tox-lsr 3.17.1 has a fix for the broken container tests
There was one shell function for both setting up the callback plugins and the connection plugin.
When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not
set, so all subsequent tests failed. The connection plugin must be present and the env. var.
must be set in order to run any container tests. The code was fixed to ensure that there is
always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS
is always set and contains this path.
Also, setting up the callback plugins and the connection plugin is already idempotent, so no
reason to skip them.
Signed-off-by: Rich Megginson rmeggins@redhat.com