fix: update systemd service dependencies for ApplicationManager1 #284
Conversation
Reviewer's GuideThe pull request adjusts the systemd target dependency for ApplicationManager1 by changing references from dde-session-initialized.target to dde-session-core.target in both the CMake installation step and the service unit template, ensuring proper initialization order. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @yixinshark - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
TAG Bot New tag: 1.2.34 |
|
TAG Bot New tag: 1.2.35 |
|
TAG Bot New tag: 1.2.36 |
|
TAG Bot New tag: 1.2.38 |
There was a problem hiding this comment.
Pull request overview
This pull request updates the systemd service dependencies for ApplicationManager1 from dde-session-initialized.target to dde-session-core.target, reflecting a change in the session initialization architecture. The changes ensure that the ApplicationManager service integrates with the new session target structure.
Key Changes:
- Updated systemd service file to use
dde-session-core.targetinstead ofdde-session-initialized.target - Removed the
Requisitedependency directive while keepingPartOfandBeforedirectives - Updated CMakeLists.txt symlink installation to place the service in the correct target's wants directory
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| misc/systemd/user/org.desktopspec.ApplicationManager1.service.in | Updated service dependencies to reference dde-session-core.target; removed Requisite directive |
| misc/CMakeLists.txt | Updated symlink target from dde-session-initialized.target.wants to dde-session-core.target.wants |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
TAG Bot New tag: 1.2.39 |
|
TAG Bot New tag: 1.2.40 |
|
TAG Bot New tag: 1.2.41 |
|
这个提交还需要吗？怎么不加reviewer？ |
|
TAG Bot New tag: 1.2.42 |
|
TAG Bot New tag: 1.2.43 |
|
TAG Bot New tag: 1.2.44 |
Changed the symlink target in CMakeLists.txt from dde-session-initialized.target to dde-session-core.target. Updated the service file to reflect the new dependencies, replacing references to dde-session-initialized.target with dde-session-core.target. This ensures proper service management and initialization order. Log: as title
yixinshark
force-pushed
the
fix-service
branch
from
2155d36 to
fe15345
Compare
deepin pr auto review这段代码修改主要是将一个 systemd 服务单元的符号链接从 以下是针对该修改的详细审查意见，包括语法逻辑、代码质量、代码性能和代码安全四个方面： 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
综合改进建议
总结：代码修改本身没有语法错误，符合 CMake 规范。主要风险在于 Systemd 服务启动顺序的变更可能引发的依赖问题。请务必确认 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
4 participants
Changed the symlink target in CMakeLists.txt from dde-session-initialized.target to dde-session-core.target. Updated the service file to reflect the new dependencies, replacing references to dde-session-initialized.target with dde-session-core.target. This ensures proper service management and initialization order.
Log: as title
Summary by Sourcery
Update systemd service dependencies for ApplicationManager1 to depend on dde-session-core.target instead of dde-session-initialized.target.
Bug Fixes:
Build: