Skip to content

Conversation

@Johnson-zs
Copy link
Contributor

@Johnson-zs Johnson-zs commented Jun 27, 2025

Summary by Sourcery

Bump package to version 1.5.6 and remove the obsolete Australian English translation file

Build:

  • Update debian/changelog for the 1.5.6 release

Chores:

  • Remove translations/dde-device-formatter_en_AU.ts

Deleted the `en_AU.ts` translation file as it is no longer needed.

Log: Deleted the `en_AU.ts` translation file as it is no longer needed.
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai
Copy link

sourcery-ai bot commented Jun 27, 2025

Reviewer's Guide

This PR updates the package to version 1.5.6 by revising the Debian changelog and removes the Australian English translation file for the device formatter.

File-Level Changes

Change Details Files
Bump package version and update changelog
  • Add new 1.5.6 entry
  • Update date and urgency fields
  • Adjust formatting for consistency
debian/changelog
Remove Australian English translation
  • Delete en_AU TS translation file
translations/dde-device-formatter_en_AU.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Johnson-zs - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见

1. 代码注释和文档

  • 建议:在删除的翻译文件中,应该添加注释说明为什么删除该文件,以及是否有替代的翻译文件或者处理方式。

2. 代码风格

  • 建议:在删除文件时,可以添加一行注释说明该文件已被删除,以便其他开发者了解背景信息。

3. 代码质量

  • 建议:虽然删除了文件,但应确保没有其他地方引用了该文件,以避免潜在的编译错误。

4. 代码性能

  • 建议:没有性能相关的改动,因为这是一个简单的文件删除操作。

5. 代码安全

  • 建议:没有安全相关的改动,因为这是一个翻译文件的删除操作,不涉及敏感数据。

具体修改建议

debian/changelog文件中,可以添加一行注释,说明删除的文件及其原因:

+dde-device-formatter (1.5.6) unstable; urgency=medium
+
+  * remove obsolete English translation file 
+  * Note: The file 'dde-device-formatter_en_AU.ts' has been removed as it is no longer needed.
+
+ -- Zhang Sheng <zhangsheng@uniontech.com>  Fri, 27 Jun 2025 17:11:30 +0800

这样,其他开发者可以更容易理解为什么删除了这个文件。

@Johnson-zs
Copy link
Contributor Author

/forcemerge

@github-actions
Copy link

TAG Bot

TAG: 1.5.6
EXISTED: no
DISTRIBUTION: unstable

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 27, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 8d004a8 into linuxdeepin:master Jun 27, 2025
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants