Skip to content

Conversation

@JWWTSL
Copy link
Contributor

@JWWTSL JWWTSL commented Aug 7, 2025

log: Translation update

Summary by Sourcery

Add Lao (lo) locale translations for the dde-device-formatter application and record the update in the Debian changelog.

Enhancements:

  • Introduce translations/dde-device-formatter_lo.ts containing Lao translations for all UI strings and dialogs.

Build:

  • Update debian/changelog with a translation update entry.

@github-actions
Copy link

github-actions bot commented Aug 7, 2025

TAG Bot

TAG: 1.5.7
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见如下:

  1. 版本更新注释

    • changelog文件中,版本更新注释应该更详细地说明更新内容,而不仅仅是“Update version to 1.5.7”。建议添加具体的功能改进或修复的描述。
  2. 翻译文件新增

    • 新增的dde-device-formatter_lo.ts文件中,翻译内容看起来是正确的,但需要确保所有翻译都经过校对,并且符合目标语言的使用习惯。
  3. 未完成的翻译

    • mainwindow.cpp文件中,Continue的翻译是<translation type="unfinished"></translation>,这表示该翻译尚未完成。应该尽快完成所有未完成的翻译,或者标记为待定。
  4. 代码注释

    • ts文件中,每个<message>标签下应该添加注释,说明该消息的用途或上下文,以便其他开发者理解。
  5. 语言一致性

    • QCoreApplication的翻译中,System Disk的翻译ລាស់ដុស්කូ可能不符合目标语言的使用习惯,建议检查并修正。
  6. 错误信息翻译

    • main.cpp文件中,错误信息翻译Device does not existThe device is read-only可能需要更具体的描述,以便用户理解错误原因。
  7. 代码风格

    • 确保所有新增的翻译文件遵循项目的代码风格指南,包括缩进、空格和换行等。
  8. 国际化

    • 考虑到国际化,建议在ts文件中添加对其他语言的支持,如英语,以便于非目标语言用户的使用。
  9. 文件命名

    • 确保所有新增的翻译文件命名符合项目的命名规范,例如使用语言代码作为文件名的一部分。
  10. 测试

    • 在进行翻译更新后,应该进行充分的测试,确保翻译不会影响程序的功能和用户体验。

总体来说,代码审查的重点是确保翻译的准确性、完整性,以及代码风格的一致性。同时,还需要关注版本更新注释的详细性和未完成翻译的处理。

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 7, 2025

Reviewer's Guide

Adds full Lao locale support by introducing a new translation file with Lao strings for all UI contexts and updates the package changelog to record the translation update.

File-Level Changes

Change Details Files
Add Lao locale translations
  • Introduce translations/dde-device-formatter_lo.ts with Lao strings covering all UI contexts
translations/dde-device-formatter_lo.ts
Update package changelog
  • Append translation update entry to debian/changelog
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JWWTSL - I've reviewed your changes - here's some feedback:

  • There’s an empty translation for “Continue” – please provide the Lao equivalent.
  • Most of the strings look like Thai rather than Lao script – double-check that these translations match the lo locale.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There’s an empty translation for “Continue” – please provide the Lao equivalent.
- Most of the strings look like Thai rather than Lao script – double-check that these translations match the lo locale.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, JWWTSL, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lzwind lzwind merged commit b97f68e into linuxdeepin:master Aug 7, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants