Skip to content

Conversation

@add-uos
Copy link
Contributor

@add-uos add-uos commented Oct 16, 2025

  • Removed pkg-config from Build-Depends in Debian packaging configuration
  • Maintained other essential build dependencies including cmake, debhelper, and Qt6 toolchain
  • Simplified package build requirements while ensuring compatibility

Log: Update build dependencies for license compliance

Summary by Sourcery

Adjust Debian packaging to streamline build dependencies by removing pkg-config and ensuring essential tools remain for compatibility and compliance

Enhancements:

  • Simplify Debian packaging build dependencies for license compliance

Build:

  • Remove pkg-config from Debian Build-Depends while retaining cmake, debhelper, and Qt6 toolchain

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 16, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This pull request streamlines the Debian packaging configuration by removing pkg-config from the Build-Depends list to ensure open source license compliance while retaining the essential cmake, debhelper, and Qt6 toolchain dependencies.

File-Level Changes

Change Details Files
Simplify Debian Build-Depends list
  • Removed pkg-config entry from Build-Depends
  • Confirmed cmake, debhelper, and Qt6 toolchain remain unchanged
debian/control

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

- Removed pkg-config (GPL-2.0-or-later) from Build-Depends in Debian packaging configuration
- Maintained other essential build dependencies including cmake, debhelper, and Qt6 toolchain
- Simplified package build requirements while ensuring compatibility

Log: Update build dependencies for license compliance
@deepin-ci-robot
Copy link

deepin pr auto review

我对这个git diff进行审查:

  1. 语法逻辑:

    • 这个diff从debian/control文件中移除了"pkg-config"作为Build-Depends
    • 语法上没有问题,删除格式正确
  2. 代码质量:

    • 移除pkg-config依赖可能是合理的,如果项目不再需要它
    • 但需要确认项目构建过程中是否真的不再需要pkg-config
  3. 代码性能:

    • 移除不必要的依赖可以略微提高构建速度
    • 但影响很小,因为pkg-config本身就是一个轻量级工具
  4. 代码安全:

    • 移除依赖本身不会引入安全问题
    • 但需要确保移除后不会导致构建过程中缺少必要的配置信息

改进建议:

  1. 在移除pkg-config依赖前,应该确认:

    • 项目中的所有组件是否都不再需要pkg-config
    • 是否有其他依赖项间接依赖pkg-config
    • 构建过程是否仍然需要pkg-config来查找某些库的配置
  2. 建议添加注释说明为什么移除pkg-config依赖,以便其他维护者理解变更原因

  3. 如果项目确实不再需要pkg-config,建议在changelog中记录这次变更,说明移除的原因

  4. 考虑创建一个测试构建,确保移除pkg-config后项目仍然可以正常构建和安装

总的来说,这个变更本身没有问题,但需要确保它不会影响项目的构建过程。建议在完全确认不再需要pkg-config后再进行这个更改。

@Johnson-zs Johnson-zs merged commit 152276c into linuxdeepin:master Oct 16, 2025
18 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, Johnson-zs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants