Skip to content

Perf: [cppcheck] parameter should be passed by const reference. #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-bot merged 1 commit into from
Jul 29, 2025
Merged

Perf: [cppcheck] parameter should be passed by const reference. #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions deepin-devicemanager/src/DeviceManager/DeviceGpu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,12 +168,12 @@ bool DeviceGpu::setHwinfoInfo(const QMap<QString, QString> &mapInfo)
foreach (const QString &item, items) {
if (item.isEmpty())
continue;
QStringList items = allStr.split(":", QString::SkipEmptyParts);
if (items.size() != 2)
QStringList tmpItems = allStr.split(":", QString::SkipEmptyParts);
if (tmpItems.size() != 2)
continue;
if (items.first().trimmed() == "VRAM total size") {
if (tmpItems.first().trimmed() == "VRAM total size") {
bool ok;
quint64 vramSize = items.last().trimmed().toULong(&ok, 16);
quint64 vramSize = tmpItems.last().trimmed().toULong(&ok, 16);
if (ok && vramSize >= 1048576) {
vramSize /= 1048576;
auto curSize = vramSize / 1024.0;
Expand Down
2 changes: 1 addition & 1 deletion deepin-devicemanager/src/DeviceManager/DeviceManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1299,7 +1299,7 @@ DeviceBaseInfo *DeviceManager::getNetworkDevice(const QString &unique_id)
return nullptr;
}

void DeviceManager::correctNetworkLinkStatus(QString linkStatus, QString networkDriver)
void DeviceManager::correctNetworkLinkStatus(const QString &linkStatus, const QString &networkDriver)
{
if (m_ListDeviceNetwork.size() == 0)
return;
Expand Down
2 changes: 1 addition & 1 deletion deepin-devicemanager/src/DeviceManager/DeviceManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ class DeviceManager : public QObject
* @brief correctNetworkLinkStatus:校正网络连接状态
* @param linkStatus:连接状态
*/
void correctNetworkLinkStatus(QString linkStatus, QString networkDriver);
void correctNetworkLinkStatus(const QString &linkStatus, const QString &networkDriver);

/**
* @brief networkDriver:获取所有网络驱动
Expand Down
2 changes: 1 addition & 1 deletion deepin-devicemanager/src/DeviceManager/DeviceNetwork.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,10 @@
return m_Enable;
}

void DeviceNetwork::correctCurrentLinkStatus(QString linkStatus)
void DeviceNetwork::correctCurrentLinkStatus(const QString &linkStatus)
{
if (m_Link != linkStatus)
m_Link = linkStatus;

Check warning on line 230 in deepin-devicemanager/src/DeviceManager/DeviceNetwork.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

The statement 'if (m_Link!=linkStatus) m_Link=linkStatus' is logically equivalent to 'm_Link=linkStatus'.
}

QString DeviceNetwork::logicalName()
Expand Down
2 changes: 1 addition & 1 deletion deepin-devicemanager/src/DeviceManager/DeviceNetwork.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class DeviceNetwork : public DeviceBaseInfo
* @brief correctCurrentLinkStatus
* @param linkStatus
*/
void correctCurrentLinkStatus(QString linkStatus);
void correctCurrentLinkStatus(const QString &linkStatus);

/**
* @brief logicalName: 获取网卡逻辑名称
Expand Down