-
Notifications
You must be signed in to change notification settings - Fork 40
fix: [cppcheck] Improve code formatting for architecture mapping #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReformatted static QMap initializations for architecture mapping and aligned declaration of error string map to improve code readability and maintain consistent styling. Class diagram for updated QMap initializationsclassDiagram
class commonfunction {
+static QMap<QString, QString> mapArch
}
class commontools {
+static QMap<DriverType, QString> m_MapDriverType
+static QMap<Status, QString> m_MapStatusIcon
+static QMap<Status, QString> m_MapStatusType
+static QMap<int, QString> m_MapErrorString
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enhanced readability of the architecture mapping table by reformatting the static QMap initialization with proper indentation and line breaks. also add comments for variables. Log: Refactor architecture mapping code style Change-Id: Iea19f9e13e7b8f59f66d34877e555994832a0221
838f173 to
b4bbe0c
Compare
deepin pr auto review根据提供的git diff内容,我将从代码质量、语法逻辑、性能和安全性等方面进行分析并提出改进建议:
总的来说,这些修改主要是关于代码格式、注释和变量命名的改进,这些改动有助于提高代码的可读性和可维护性。同时,也发现了一些潜在的问题,如变量拼写错误和可能的性能问题,建议在后续开发中加以注意和改进。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/merge |
Enhanced readability of the architecture mapping table by reformatting the static QMap initialization with proper indentation and line breaks.
Log: Refactor architecture mapping code style
Change-Id: Iea19f9e13e7b8f59f66d34877e555994832a0221
Summary by Sourcery
Reformat static QMap initializations across source and header files to enhance readability and maintain a consistent code style.
Enhancements: