fix: Clear driver field when value is usbfs

[add-uos]

Added condition to reset the driver information when its value is "usbfs" (case-insensitive comparison) to handle invalid driver identifiers.

Log: Filter out usbfs driver values
Bug: https://pms.uniontech.com/bug-view-333969.html
Change-Id: I4f2632c9ccef6f9df668460adda9b9078a65b932

Summary by Sourcery

Bug Fixes:

• Clear the driver field when its value is 'usbfs' in both lshw- and hwinfo-based device information

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduce a case-insensitive filter for the ‘usbfs’ driver identifier by clearing the driver field when encountered in both setInfoFromLshw and setInfoFromHwinfo, preventing invalid driver values from persisting.

Class diagram for updated DeviceOthers driver handling

classDiagram
    class DeviceOthers {
        - QString m_Driver
        + void setInfoFromLshw(const QMap<QString, QString> &mapInfo)
        + void setInfoFromHwinfo(const QMap<QString, QString> &mapInfo)
    }
    DeviceOthers : setInfoFromLshw()
    DeviceOthers : setInfoFromHwinfo()
    DeviceOthers : m_Driver
    %% Highlight the new logic for clearing m_Driver when value is 'usbfs'

Loading

File-Level Changes

Change	Details	Files
Clear m_Driver when its value is ‘usbfs’ (case-insensitive)	Added a condition in setInfoFromLshw to check if m_Driver.toLower() == "usbfs" and clear it Added the same usbfs check and clear logic in setInfoFromHwinfo	deepin-devicemanager/src/DeviceManager/DeviceOthers.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

我对这段代码进行了审查，以下是我的分析和改进建议：

代码逻辑审查

1. 重复代码：
   在 setInfoFromLshw 和 setInfoFromHwinfo 两个函数中都有相同的代码片段：

   if (m_Driver.toLower() == "usbfs")
       m_Driver.clear();

   这部分代码重复了，可以考虑提取为一个私有辅助函数。

2. 条件判断逻辑：

   if(m_Driver.isEmpty() && !m_Avail.compare("yes", Qt::CaseInsensitive)){
       setForcedDisplay(true);
       setCanEnale(false);

   这里的 m_Avail 变量名拼写有误，应该是 "Enable" 而不是 "Enale"。

3. 字符串比较：
   代码使用了 Qt::CaseInsensitive 进行不区分大小写的比较，这是一个好的实践，但建议在常量定义中统一管理这些比较标志。

代码质量改进建议

1. 提取重复代码：
   可以创建一个私有函数来处理 USBFS 驱动清除逻辑：

   void DeviceOthers::clearUsbfsDriver() {
       if (m_Driver.toLower() == "usbfs")
           m_Driver.clear();
   }

2. 修正拼写错误：
   将 setCanEnale 修正为 setCanEnable。

3. 添加注释：
   对于清除 USBFS 驱动的逻辑，应该添加注释说明原因：

   // Clear usbfs driver as it's a virtual filesystem, not a real driver
   clearUsbfsDriver();

代码性能改进建议

1. 字符串处理优化：
   当前代码中多次调用 toLower()，可以考虑在比较前先将字符串转换为小写并缓存结果，特别是在循环或频繁调用的场景中。

2. 避免不必要的比较：
   在 clearUsbfsDriver() 函数中，可以先检查字符串是否以 "usb" 开头，再进行完整比较，这样可以减少一些不必要的字符串操作。

代码安全改进建议

1. 输入验证：
   在使用 mapInfo 中的值之前，应该检查这些值是否存在，避免潜在的空指针或未定义行为。

2. 字符串安全性：
   考虑使用 QString::compare 的重载版本，明确指定比较方式，避免隐式转换可能带来的问题。

综合改进建议

1. 重构后的代码示例：

   void DeviceOthers::setInfoFromLshw(const QMap<QString, QString> &mapInfo)
   {
       // ... 其他代码 ...
       
       // Clear usbfs driver as it's a virtual filesystem, not a real driver
       clearUsbfsDriver();
       
       if(m_Driver.isEmpty() && !m_Avail.compare("yes", Qt::CaseInsensitive)){
           setForcedDisplay(true);
           setCanEnable(false);  // 修正拼写错误
       }
       
       // ... 其他代码 ...
   }
   
   void DeviceOthers::setInfoFromHwinfo(const QMap<QString, QString> &mapInfo)
   {
       // ... 其他代码 ...
       
       // Clear usbfs driver as it's a virtual filesystem, not a real driver
       clearUsbfsDriver();
       
       // ... 其他代码 ...
   }
   
   void DeviceOthers::clearUsbfsDriver()
   {
       // 优化：先检查前缀，再进行完整比较
       if (!m_Driver.isEmpty() && m_Driver.size() >= 4 && 
           m_Driver.leftRef(4).toLower() == "usbfs") {
           m_Driver.clear();
       }
   }

这些改进可以提高代码的可维护性、性能和安全性，同时减少潜在的错误。

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, max-lvs

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[SunStorm2018]

/merge

[deepin-bot]

Permission denied

[add-uos]

/merge