-
Notifications
You must be signed in to change notification settings - Fork 40
fix: [typo] Correct spelling errors in EDIDparser. #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed typos in method name and variable comments to ensure consistent and correct spelling: - Changed parserVendor() to parseVendor() across both declaration and implementation - Fixed "heigth" to "height" in method comments and variable descriptions Log: Fix spelling errors in EDID parser Change-Id: Ia15db2bf96f2e145718981592e69dca3e740172c
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRenamed the parserVendor method to parseVendor across declarations, definitions, and call sites, and corrected the spelling of “height” in comments and member descriptions to ensure consistency. Class diagram for EDIDParser after typo correctionsclassDiagram
class EDIDParser {
+int height()
-void parseVendor()
-void parseReleaseDate()
QString m_MonitorName
bool m_LittleEndianMode
int m_Width
int m_Height
QStringList m_ListEdid
QMap<QString, QString> m_MapCh
}
Flow diagram for method renaming from parserVendor to parseVendorflowchart TD
A["EDIDParser::setEdid()"] --> B["parseVendor()"]
B --> C["parseReleaseDate()"]
C --> D["Other parsing steps..."]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来审查这段代码的变更,主要涉及函数命名、注释和变量名的修正: 1. 函数命名修正
2. 注释改进
3. 变量名修正
4. 整体评价这些修改都是积极且必要的:
建议改进虽然这些修改已经很好,但我还可以提出以下几点建议:
总的来说,这些修改提高了代码的一致性和可读性,是积极的改进。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, max-lvs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/merge |
Fixed typos in method name and variable comments to ensure consistent and correct spelling:
Log: Fix spelling errors in EDID parser
Change-Id: Ia15db2bf96f2e145718981592e69dca3e740172c
Summary by Sourcery
Fix typos in EDIDParser by renaming parserVendor to parseVendor and correcting height-related misspellings in code comments and variables
Bug Fixes: