Skip to content

Conversation

@add-uos
Copy link
Contributor

@add-uos add-uos commented Dec 1, 2025

pick develop/eagle to master

add-uos and others added 5 commits December 1, 2025 13:25
Maintain the monitor info of supported resolutions in special machine.

pick from: linuxdeepin@b71dbea

Log: Maintain the monitor info in special machine.
Bug: https://pms.uniontech.com/bug-view-325731.html
Change-Id: Iddfadc1ab05f3b81df5469240fde4346ac35e378
-- Clear the preview cache to avoid duplicate infomation accumulation.

Log: add feature for GPU.
Task: https://pms.uniontech.com/task-view-378987.html
-- improve loop performance and reduce stuttering.

Log: add feature for GPU.
Task: https://pms.uniontech.com/task-view-378987.html
-- In some special computer, the GPU info not show.
-- Add logic to show GPU info.
-- Remove duplicate code and improve code readability.

pick from: linuxdeepin@553f3a9

Log: add feature for GPU.
Task: https://pms.uniontech.com/task-view-378987.html
-- Variable 'ret' is reassinged a value befor the old one has been used.

pcik from: linuxdeepin@10e0f89
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @add-uos, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@deepin-ci-robot
Copy link

deepin pr auto review

我来对这个git diff进行审查,主要关注代码逻辑、性能、安全性等方面的问题。

  1. 代码逻辑改进建议:
  • 在多个文件中,移除了setTomlAttribute的返回值赋值操作,这可能会导致错误处理逻辑的缺失。建议在关键属性设置时保留返回值检查,或者在setTomlAttribute内部实现统一的错误处理机制。
  1. 代码性能改进建议:
  • DeviceMonitor.cpp中,将分辨率处理相关的代码移到了Common::specialComType > 0的条件判断中,这样可以避免不必要的字符串处理操作,是个好的优化。
  • HWGenerator.cpp中将parseEDID函数移到了CommonTools类中,提高了代码复用性,是个好的重构。
  1. 代码安全改进建议:
  • DeviceMonitor.cpp中的xrandr处理逻辑增加了条件判断,避免在特定环境下执行可能有问题的操作,提高了安全性。
  1. 代码质量改进建议:
  • MainWindow.cpp中增加了Common::specialComType的判断条件,使代码逻辑更加清晰。
  • DeviceInfo.cpp中将迭代器类型改为const_iterator,这是一个好的实践,可以防止意外的修改。
  1. 其他建议:
  • DeviceMonitor.cpp中关于分辨率处理的代码重复出现多次,建议将这部分逻辑提取为独立函数。
  • 建议在Common::specialComType的使用处添加注释说明其具体含义,以提高代码可读性。

总体来说,这次改动主要优化了代码逻辑和性能,提高了代码的安全性,但需要注意错误处理机制的完整性。建议在后续开发中保持这些良好的编程实践。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos, lzwind

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@add-uos
Copy link
Contributor Author

add-uos commented Dec 1, 2025

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Dec 1, 2025

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 869b840 into linuxdeepin:master Dec 1, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants