sync: from linuxdeepin/dtkdeclarative

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#522

Summary by Sourcery

Expose configurable flags for enabling or disabling copy and cut actions in text input components by synchronizing updates from linuxdeepin/dtkdeclarative.

New Features:

• Introduce copyMenuEnabled and cutMenuEnabled properties in TextField to toggle context menu options
• Add setCopyEnable and setCutEnable methods in PasswordEdit to control copy and cut functionality

Enhancements:

• Update Copy and Cut menu items to respect the new copyMenuEnabled and cutMenuEnabled flags

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR syncs QML sources from linuxdeepin/dtkdeclarative and enhances text input components by introducing copy/cut enable flags with corresponding setters, and updates menu item behaviors to respect those flags.

Class diagram for updated TextField and PasswordEdit QML components

classDiagram
    class TextField {
        +bool copyMenuEnabled = true
        +bool cutMenuEnabled = true
        ...
    }
    class PasswordEdit {
        +setCopyEnable(enable)
        +setCutEnable(enable)
        ...
    }
    PasswordEdit --> TextField : uses

Loading

Flow diagram for Copy and Cut menu item enablement logic

flowchart TD
    A[User selects text in TextField] --> B{Is echoMode Normal?}
    B -- No --> D[Copy/Cut disabled]
    B -- Yes --> C{Are copyMenuEnabled/cutMenuEnabled true?}
    C -- No --> D[Copy/Cut disabled]
    C -- Yes --> E[Copy/Cut enabled]

Loading

File-Level Changes

Change	Details	Files
Expose copy/cut enable toggles in PasswordEdit	Added setCopyEnable(enable) function Added setCutEnable(enable) function	qt6/src/qml/PasswordEdit.qml
Declare copy/cut enable properties in TextField	Added copyMenuEnabled property (default true) Added cutMenuEnabled property (default true)	qt6/src/qml/TextField.qml
Update Copy/Cut menu items to respect enable flags	Include copyMenuEnabled in Copy enabled condition Include cutMenuEnabled in Cut enabled condition	qt6/src/qml/TextField.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

deepin pr auto review

我来对这段代码进行审查，并提出改进意见：

语法逻辑

1. 代码逻辑基本正确，新增的 canCopy 和 canCut 属性很好地封装了复制和剪切的判断逻辑。
2. 在 Keys.onPressed 处理函数中，对于不符合条件的按键事件直接返回，避免了不必要的处理。
3. Keys.enabled 的设置可能有误，当前设置为 !canCopy || !canCut，这意味着当任一条件为false时按键就会被禁用，这不是我们想要的行为。应该是 canCopy || canCut 更合适，表示当任一条件满足时按键应该可用。

代码质量

1. 使用属性别名 canCopy 和 canCut 是一个好的实践，提高了代码的可读性和可维护性。
2. 将重复的条件判断提取为属性，减少了代码重复。
3. 建议为 Keys.enabled 添加注释，说明其用途，因为当前设置可能不够直观。

代码性能

1. 使用属性而不是重复的条件判断有助于性能优化，因为属性值会被缓存。
2. 在事件处理函数中提前返回可以避免不必要的处理，有助于性能。

代码安全

1. 对于复制和剪切操作的条件检查是适当的，确保了操作的安全性。
2. 建议在 Keys.onPressed 处理函数中添加对 event 的空值检查，以防止潜在的空引用异常。

改进建议

1. 修正 Keys.enabled 的逻辑：

Keys.enabled: canCopy || canCut  // 当任一操作可用时，按键应该启用

2. 添加注释以提高代码可读性：

// 当复制或剪切可用时，启用键盘快捷键
Keys.enabled: canCopy || canCut

3. 在事件处理函数中添加空值检查：

Keys.onPressed: function(event) {
    if (!event) return;
    
    if (event.matches(StandardKey.Copy)) {
        if (!canCopy) {
            event.accepted = true
            return
        }
    } else if (event.matches(StandardKey.Cut)) {
        if (!canCut) {
            event.accepted = true
            return
        }
    }
}

4. 考虑将键盘快捷键的处理逻辑提取到一个单独的函数中，以提高代码的可维护性：

function handleKeyEvent(event) {
    if (!event) return false;
    
    if (event.matches(StandardKey.Copy)) {
        return canCopy;
    } else if (event.matches(StandardKey.Cut)) {
        return canCut;
    }
    return false;
}

Keys.onPressed: function(event) {
    if (!handleKeyEvent(event)) {
        event.accepted = true;
    }
}

这些改进将使代码更加健壮、可维护，并且逻辑更加清晰。

[pengfeixx]

/forcemerge

[deepin-bot]

Permission denied