sync: from linuxdeepin/dtkdeclarative

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#524

Summary by Sourcery

Synchronize ArrowListView components from upstream dtkdeclarative and enhance their interactivity and styling.

New Features:

• Add hover-based auto-scrolling for ArrowListView buttons with initial delay and continuous scrolling

Enhancements:

• Replace Button with ActionButton for consistent styling and remove explicit text color
• Switch arrow buttons to fill available width instead of using a fixed preferred width

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepin-ci-robot]

deepin pr auto review

我对这个代码变更进行审查，并提供以下改进意见：

1. 语法逻辑

优点：

• 代码逻辑清晰，使用了状态机的方式处理滚动操作
• 使用了Timer来实现延迟和连续滚动，逻辑合理

改进建议：

• 在performScroll函数中，建议添加边界检查，防止在滚动到边界时继续操作
• shouldAutoScroll和delayCompleted的状态管理可以考虑使用Qt的状态机来实现，这样可以更清晰地管理状态转换

2. 代码质量

优点：

• 代码结构清晰，注释完善
• 将滚动操作封装为单独的函数，提高了代码复用性

改进建议：

• 建议将滚动延迟时间和间隔时间定义为可配置的常量，而不是硬编码在代码中
• 可以考虑将滚动逻辑提取到一个单独的组件中，提高代码的可维护性
• 添加适当的错误处理机制，防止在view未初始化时发生错误

3. 代码性能

优点：

• 使用了Loader来动态加载按钮组件，提高了性能
• 使用Timer来控制滚动，避免了不必要的性能开销

改进建议：

• 在滚动过程中，可以考虑添加性能监控，确保滚动操作不会导致UI卡顿
• 对于大量数据的情况，可以考虑使用虚拟滚动技术来优化性能
• 可以考虑添加滚动动画，提高用户体验

4. 代码安全

优点：

• 使用了enabled属性来控制按钮的可点击状态，防止在边界时继续操作
• 使用了条件判断来确保滚动操作的安全性

改进建议：

• 建议添加更多的边界检查，确保在view为null或未初始化时不会发生错误
• 考虑添加异常处理机制，防止在滚动过程中出现未预期的错误
• 建议添加日志记录，便于追踪和调试可能出现的问题

总结建议：

1. 将硬编码的值提取为可配置的常量
2. 添加更多的边界检查和错误处理
3. 考虑使用Qt状态机来管理滚动状态
4. 添加性能监控和优化措施
5. 增强代码的可维护性和可扩展性

这些改进将有助于提高代码的质量、性能和安全性，同时提供更好的用户体验。

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Ensure both initialDelayTimer and hoverScrollTimer are stopped in onShouldAutoScrollChanged to avoid lingering timers after auto-scroll ends.
• Instead of setting palette.windowText to undefined, explicitly bind the text color to the appropriate theme role for more predictable styling.
• Verify that switching from Layout.preferredWidth to Layout.fillWidth doesn’t disrupt the intended button sizing in varied container layouts.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- Ensure both initialDelayTimer and hoverScrollTimer are stopped in onShouldAutoScrollChanged to avoid lingering timers after auto-scroll ends.
- Instead of setting palette.windowText to undefined, explicitly bind the text color to the appropriate theme role for more predictable styling.
- Verify that switching from Layout.preferredWidth to Layout.fillWidth doesn’t disrupt the intended button sizing in varied container layouts.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

Reviewer's Guide

This PR syncs qml components from linuxdeepin/dtkdeclarative by replacing the Button implementation with ActionButton in ArrowListViewButton, refactoring scroll logic into a reusable function, adding hover-based auto-scroll via timers, and updating the arrow button layout to use fillWidth.

File-Level Changes

Change	Details	Files
Replace Button with ActionButton and palette override	Replaced flat Button with ActionButton component Added undefined palette.windowText override for consistent styling	qt6/src/qml/private/ArrowListViewButton.qml
Extract scroll actions into performScroll function	Removed inline onClicked handlers Added performScroll() to centralize increment/decrement logic	qt6/src/qml/private/ArrowListViewButton.qml
Implement hover auto-scroll using timers and state properties	Added shouldAutoScroll and delayCompleted properties Defined initialDelayTimer for delay and hoverScrollTimer for continuous scrolling Reset delayCompleted when hover auto-scroll stops	qt6/src/qml/private/ArrowListViewButton.qml
Update arrow button layout to use fillWidth	Replaced Layout.preferredWidth with Layout.fillWidth on both Up and Down buttons	qt6/src/qml/ArrowListView.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.