sync: from linuxdeepin/dtkdeclarative

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#525

Summary by Sourcery

Bug Fixes:

• Adjust ScrollBar.qml state condition to require AlwaysOn policy only when not hovered or pressed

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR syncs the ScrollBar.qml implementation from linuxdeepin/dtkdeclarative, refining the display logic in the normal state by tightening the AlwaysOn policy conditions.

File-Level Changes

Change	Details	Files
Refine ScrollBar normal-state visibility logic	Added !control.hovered and !control.pressed checks to the AlwaysOn condition Preserved existing moving & size-based visibility condition	qt6/src/qml/ScrollBar.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

deepin pr auto review

我对这个ScrollBar.qml的代码变更进行审查，主要关注语法逻辑、代码质量、性能和安全性：

1. 语法逻辑分析：

• 修改前的代码中，每个状态（normal、hover、active）都包含"control.policy === T.ScrollBar.AlwaysOn"条件，这会导致无论policy设置如何，滚动条都会一直显示
• 修改后的代码移除了这个冗余条件，使滚动条的显示逻辑更加合理

2. 代码质量改进：

• 修改后的代码逻辑更加清晰，每个状态的条件更加明确
• 移除了重复的条件判断，提高了代码的可维护性
• 状态之间的互斥性更好，避免了状态重叠的问题

3. 性能优化：

• 减少了重复的条件判断，特别是在频繁的状态切换时
• 简化了状态判断逻辑，减少了不必要的计算
• 移除了冗余的条件检查，提高了渲染效率

4. 安全性考虑：

• 修改后的代码逻辑更加严格，只有在特定条件下才会触发相应状态
• 避免了不必要的显示，减少了潜在的用户交互问题
• 状态切换条件更加明确，减少了意外的状态转换

建议：

1. 可以考虑添加注释，说明各个状态的触发条件和用途，提高代码可读性
2. 建议添加边界条件检查，确保size参数的有效性
3. 考虑添加日志记录，便于调试状态切换问题
4. 可以添加单元测试，确保各种状态切换的正确性

总体而言，这次修改提高了代码质量和性能，使滚动条的显示逻辑更加合理和高效。