sync: from linuxdeepin/dtkdeclarative#299
Merged
18202781743 merged 1 commit intomasterfrom Sep 4, 2025
Merged
Conversation
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#526
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepin-ci-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
deepin pr auto review我对这段代码审查如下:
改进建议:
// 仅在列表可交互且不在顶部时显示向上箭头
visible: itemsView.interactive && !itemsView.atYBeginning
// 仅在列表可交互且不在底部时显示向下箭头
visible: itemsView.interactive && !itemsView.atYEnd
总体而言,这是一个合理的改进,通过增加简单的条件判断,优化了用户界面的交互逻辑,使其更加符合用户预期。 |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR synchronizes ArrowListView.qml from the linuxdeepin repository and refines arrow button visibility by adding boundary checks, so the up arrow hides at the top and the down arrow at the bottom. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronize source files from linuxdeepin/dtkdeclarative.
Source-pull-request: linuxdeepin/dtkdeclarative#526
Summary by Sourcery
Improve ArrowListView by showing navigation arrows only when scrolling is possible and the view is interactive.
Bug Fixes: