sync: from linuxdeepin/dtkdeclarative

[deepin-ci-robot]

Synchronize source files from linuxdeepin/dtkdeclarative.

Source-pull-request: linuxdeepin/dtkdeclarative#542

Summary by Sourcery

Introduce horizontal padding properties in DialogWindow.qml and refactor its content loader to use these properties for margin configuration

Enhancements:

• Add leftPadding and rightPadding properties to DialogWindow.qml for content horizontal margins
• Update content loader layout margins to use the new padding properties instead of direct style references

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Upstream sync: Introduced leftPadding/rightPadding properties in DialogWindow.qml to centralize horizontal content margins and refactored Layout margins to use these new properties instead of direct DS.Style references.

Class diagram for updated DialogWindow.qml properties

classDiagram
    class DialogWindow {
        string icon
        alias content
        alias palette
        real leftPadding
        real rightPadding
    }
    DialogWindow : leftPadding = DS.Style.dialogWindow.contentHMargin
    DialogWindow : rightPadding = DS.Style.dialogWindow.contentHMargin
    DialogWindow --> Item : content
    Item --> Loader : contentLoader
    Loader : Layout.leftMargin = control.leftPadding
    Loader : Layout.rightMargin = control.rightPadding

Loading

File-Level Changes

Change	Details	Files
Introduce leftPadding and rightPadding properties for content horizontal margins	Add property real leftPadding initialized from DS.Style.dialogWindow.contentHMargin Add property real rightPadding initialized from DS.Style.dialogWindow.contentHMargin	qt6/src/qml/DialogWindow.qml
Refactor Layout margins to use leftPadding/rightPadding properties	Replace Layout.leftMargin DS.Style reference with control.leftPadding Replace Layout.rightMargin DS.Style reference with control.rightPadding	qt6/src/qml/DialogWindow.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

deepin pr auto review

我来对这段 QML 代码的修改进行审查：

1. 语法逻辑方面：

• 修改将原来的硬编码边距（Layout.leftMargin/RightMargin）改为了属性（leftPadding/rightPadding）
• 语法正确，没有问题
• 逻辑清晰，通过属性控制边距更加灵活

2. 代码质量方面：

• 改进点：
  • 提高了代码的可维护性和可重用性
  • 将边距值从具体实现中抽离，使代码更容易管理
  • 遵循了属性驱动的设计模式
• 建议改进：
  • 可以考虑添加 topPadding 和 bottomPadding 属性，以提供完整的内边距控制
  • 可以考虑添加 padding 属性作为一个快捷方式，同时设置所有方向的边距

3. 代码性能方面：

• 性能影响很小，只是增加了两个属性
• 属性绑定是高效的，不会造成性能问题
• 没有明显的性能优化空间

4. 代码安全方面：

• 没有安全相关的顾虑
• 修改是纯界面层面的，不涉及数据处理或安全问题

建议：

1. 可以考虑添加文档注释，说明这些属性的用途
2. 可以添加属性值的范围检查，确保边距值不会是负数
3. 考虑添加一个统一的 padding 属性，使用方式更灵活

示例改进代码：

Window {
    // ... 其他属性 ...
    
    // 添加统一的 padding 属性
    property real padding: 0
    property real leftPadding: padding || DS.Style.dialogWindow.contentHMargin
    property real rightPadding: padding || DS.Style.dialogWindow.contentHMargin
    property real topPadding: padding
    property real bottomPadding: padding
    
    // 添加属性验证
    onLeftPaddingChanged: if(leftPadding < 0) leftPadding = 0
    onRightPaddingChanged: if(rightPadding < 0) rightPadding = 0
    onTopPaddingChanged: if(topPadding < 0) topPadding = 0
    onBottomPaddingChanged: if(bottomPadding < 0) bottomPadding = 0
    
    // ... 其他代码 ...
}

总的来说，这个修改是一个很好的改进，提高了代码的灵活性和可维护性。通过添加内边距属性，使得对话框的内容区域布局更加可控。

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot, mhduiy

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment