chore: can't use ScrollView in qt5#543
Merged
18202781743 merged 1 commit intolinuxdeepin:masterfrom Oct 23, 2025
Merged
Conversation
as title.
deepin-ci-robot
added a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Oct 23, 2025
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#543
Reviewer's GuideRefactors ScrollView.qml to switch from QtQuick.Controls 2.4 to Deepin template-based T.ScrollView and custom D.ScrollBar implementations, adding explicit size calculations and integrating Deepin scrollbars for both vertical and horizontal scrolling. Class diagram for updated ScrollView.qml structureclassDiagram
class T.ScrollView {
+implicitWidth
+implicitHeight
}
class D.ScrollBar {
+vertical
+horizontal
+active
}
T.ScrollView "1" o-- "1" D.ScrollBar : vertical
T.ScrollView "1" o-- "1" D.ScrollBar : horizontal
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
mhduiy
approved these changes
Oct 23, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
18202781743
pushed a commit
to linuxdeepin/dtk6declarative
that referenced
this pull request
Oct 23, 2025
Synchronize source files from linuxdeepin/dtkdeclarative. Source-pull-request: linuxdeepin/dtkdeclarative#543
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as title.
Summary by Sourcery
Refactor the ScrollView QML component to replace the QtQuick.Controls 2.4 version with QtQuick.Templates.ScrollView and custom Deepin scrollbars for Qt5 compatibility
Enhancements: