-
Notifications
You must be signed in to change notification settings - Fork 19
feat: improve diffing between tilesets #3555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
blacha
wants to merge
38
commits into
master
Choose a base branch
from
fix/import-diff-command
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,182
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
commented
Dec 2, 2025
… and tileSetDiffLayers functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our basemaps-config preview links for Elevation inserts don’t show anything in Basemaps. You can’t see the imagery until you add the following parameters:
We need to update the code that generates the markdown QA URLs to add the
pipelineandformatkey-value parameters automatically. The code lives in the cli-config package’s [import] command.Modifications
The code for the cli-config package's
importcommand needs some re-work. We've opted to rebuild the code with a focus on improving the diffing logic and test suite. We've captured the rebuild as a newdiffcommand.packages/cli-config/src/
index.tsdiffcommand to theConfigClilist of sub commands.__tests__/
config.diff.data.ts&config.diff.test.tsconfig.diff.tsandconfig.diff.markdown.tsfiles.cli/
diff/
config.diff.tsconfig.diff.markdown.tsaction.diff.tsdiffcommand to capture the raster and vector differences between two bundled config JSON files. The command also generates new and improved markdown denoting the detected configuration changes. This command will come to replace the QA markdown role played by theimportcommand.action.import.tsoutputAnalyseReportsfunction.config.diff.tsvirtualstring to theIgnoredPropertiesarray.config/src/memory/
memory.config.tssourceproperty to theConfigProviderMemoryclass to store theURLof the bundled config.fromJsonfunction to support a newsourceUrl?: URLparameter.Verification