Skip to content

Conversation

@blacha
Copy link
Member

@blacha blacha commented Nov 4, 2025

Motivation

Our basemaps-config preview links for Elevation inserts don’t show anything in Basemaps. You can’t see the imagery until you add the following parameters:

pipeline=terrain-rgb&format=png

We need to update the code that generates the markdown QA URLs to add the pipeline and format key-value parameters automatically. The code lives in the cli-config package’s [import] command.

Modifications

The code for the cli-config package's import command needs some re-work. We've opted to rebuild the code with a focus on improving the diffing logic and test suite. We've captured the rebuild as a new diff command.

packages/cli-config/src/

  • index.ts

    • Added the new diff command to the ConfigCli list of sub commands.
  • __tests__/

    • config.diff.data.ts & config.diff.test.ts

      • Added mock data and a test suite and for validating the behaviour of the new diffing functionalities provided by the config.diff.ts and config.diff.markdown.ts files.
  • cli/

    • diff/

      • config.diff.ts

        • Implemented a new strategy for capturing the raster differences between two bundled configs. We will extend this work in the near future to capture vector differences, too.
      • config.diff.markdown.ts

        • Implemented a suite of functions for rendering the captured raster differences as markdown.
    • action.diff.ts

      • Added a new diff command to capture the raster and vector differences between two bundled config JSON files. The command also generates new and improved markdown denoting the detected configuration changes. This command will come to replace the QA markdown role played by the import command.
    • action.import.ts

      • Fixed a typo in the markdown produced by the outputAnalyseReports function.
    • config.diff.ts

      • Added the virtual string to the IgnoredProperties array.
  • config/src/memory/

    • memory.config.ts

      • Added an optional source property to the ConfigProviderMemory class to store the URL of the bundled config.
      • Extended the fromJson function to support a new sourceUrl?: URL parameter.

Verification

@blacha blacha changed the title Fix/import diff command feat: improve diffing between tilesets Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants