-
Notifications
You must be signed in to change notification settings - Fork 0
RefactoringXSLT
Goal:
- Review all services and check the one required
- Classify UI services and other services
- Classify admin, search and metadata UI
- Remove Styling, extra-HTML (eg. tables, divs, ...) and JS from XSLTs
- Move translation to i18n.xml (and identify client side translation by @js)
- Define a UI configuration (TODO: could start in XSL variable but could be nice to move that to Settings or even User Settings ?)
Note: That change should not affect legacy or widget apps and could be done in parallel
After refactoring, we should be able to safely remove :
- images/* (not harvesting, category, logo)
- loc///* (not i18n.xml)
- scripts
- WEB-INF/config-*
- xsl
Dev branch: https://github.com/fxprunayre/core-geonetwork/tree/refactoring/xslt-and-angularjs
Service configuration is defined in WEB-INF/config/config/*.xml (https://github.com/fxprunayre/core-geonetwork/tree/refactoring/xslt-and-angularjs/web/src/main/webapp/WEB-INF/config).
WEB-INF/config.xml include service configuration using (https://github.com/fxprunayre/core-geonetwork/blob/refactoring/xslt-and-angularjs/web/src/main/webapp/WEB-INF/config.xml#L1539)
<include>config/config-services.xml</include>
<include>config/config-ui.xml</include>
<include>config/config-ui-search.xml</include>
<include>config/config-ui-metadata.xml</include>
<include>config/config-ui-admin.xml</include>
During review all XSLTs are moved from the xsl folder to the xslt one (https://github.com/fxprunayre/core-geonetwork/tree/refactoring/xslt-and-angularjs/web/src/main/webapp/xslt).
- Remove all styling, uneeded HTML and JS from XSLT
- All CSS classes MUST start with "gn-" (to avoid collision when mixed in other portal, CMS, ...)
- Icons MUST come from ? eg. http://thenounproject.com/
- Icons should be stored in one file (for faster load)
- Create global variables (https://github.com/fxprunayre/core-geonetwork/blob/refactoring/xslt-and-angularjs/web/src/main/webapp/xslt/common/base-variables.xsl), functions or template to make XSLT simpler.
- TODO: XML common formating