Use "ip netns exec" instead of "nsenter" to handle pod restart in network-chaos #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing the nsenter command by ip netns exec Updating helper pod definition to mount the hostPath /var/run/netns Updating Dockerfile to add ip binary to experiments/helper pod. Signed-off-by: Calvin Audier <calvinaudier@gmail.com>
Calvinaud
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
Signed-off-by: Calvin Audier <calvinaudier@gmail.com>
Closed
9 tasks
Signed-off-by: Calvin Audier <calvinaudier@gmail.com>
|
May not be required as #761 might this the issue this PR was trying to solve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updating network-chaos to use the netns instead of the procedure to inject/remove chaos so the network-chaos can handle pod restart.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #591Special notes for your reviewer:
I think this PR will need "requires-upgrade".
Checklist:
breaking-changestagrequires-upgradetag