Skip to content

feat: show exclamation icon in square box for partial experiment completion #5267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codeEvolveZenith345 wants to merge 10 commits into from
Closed

feat: show exclamation icon in square box for partial experiment completion #5267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c14eb36
feat: show exclamation icon in square box for partial experiment comp…
codeEvolveZenith345 Oct 24, 2025
68237d1
Merge branch 'master' into exclamationInSqBox
codeEvolveZenith345 Oct 24, 2025
570717c
Merge branch 'master' into exclamationInSqBox
PriteshKiri Oct 24, 2025
a6aacc3
Merge branch 'master' into exclamationInSqBox
PriteshKiri Oct 27, 2025
82f0f16
Merge branch 'master' into exclamationInSqBox
PriteshKiri Oct 28, 2025
e009eea
Merge branch 'master' into exclamationInSqBox
PriteshKiri Oct 30, 2025
83951f4
Merge branch 'master' into exclamationInSqBox
codeEvolveZenith345 Oct 31, 2025
c2ccedc
Merge branch 'master' into exclamationInSqBox
PriteshKiri Oct 31, 2025
30b03a5
Merge branch 'master' into exclamationInSqBox
PriteshKiri Nov 11, 2025
44725ca
Merge branch 'master' into exclamationInSqBox
codeEvolveZenith345 Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions chaoscenter/web/src/components/StatusBadgeV2/StatusBadgeV2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export interface StatusProps {
iconName?: IconName;
iconSize?: number;
iconColor?: Color;
useSquareBox?: boolean; // New prop for square box icon styling
}

export function StatusBadgeV2({ status, entity, tooltip }: StatusBadgeV2Props): React.ReactElement {
Expand All @@ -48,7 +49,8 @@ export function StatusBadgeV2({ status, entity, tooltip }: StatusBadgeV2Props):
bgColor,
iconName,
iconSize = 11,
iconColor
iconColor,
useSquareBox = false // Default to false for backward compatibility
} = (() => {
switch (entity) {
case StatusBadgeEntity.ExperimentRun:
Expand All @@ -75,9 +77,24 @@ export function StatusBadgeV2({ status, entity, tooltip }: StatusBadgeV2Props):
flex={{ align: 'center-center' }}
style={{ borderRadius: 4, padding: '5px 8px', backgroundColor: bgColor }}
>
{iconName && (
{iconName && useSquareBox ? (
// Render icon inside a square box for partially completed experiments
<Container
flex={{ align: 'center-center', justifyContent: 'center' }}
style={{
width: 16,
height: 16,
border: `1.5px solid ${Utils.getRealCSSColor(color)}`,
borderRadius: 2,
marginRight: 6
}}
>
<Icon name={iconName} width={10} style={{ color: Utils.getRealCSSColor(iconColor ?? color) }} size={8} />
</Container>
) : iconName ? (
// Standard icon rendering
<Icon name={iconName} width={12} style={{ color: Utils.getRealCSSColor(iconColor ?? color) }} size={iconSize} />
)}
) : null}
<Text
margin={{ left: iconName ? 'xsmall' : 0 }}
style={{ letterSpacing: '0.1px', fontSize: 12, whiteSpace: 'nowrap' }}
Expand Down
6 changes: 4 additions & 2 deletions chaoscenter/web/src/utils/getPropsBasedOnStatus.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ export function getPropsBasedOnExperimentRunFaultStatus(status: Status): StatusP
case ExperimentRunFaultStatus.COMPLETED_WITH_ERROR: // <!-- needed for backwards compatibility -->
return {
iconName: 'error',
color: Color.ORANGE_500
color: Color.ORANGE_500,
useSquareBox: true // Add square box for partially completed
};
case ExperimentRunFaultStatus.ERROR:
case ExperimentRunFaultStatus.FAILED: // <!-- needed for backwards compatibility -->
Expand Down Expand Up @@ -95,7 +96,8 @@ export function getPropsBasedOnExperimentRunStatus(status: Status): StatusProps
return {
iconName: 'error',
color: Color.ORANGE_500,
bgColor: `var(--orange-100)`
bgColor: `var(--orange-100)`,
useSquareBox: true // Add square box for partially completed experiments
};
case ExperimentRunStatus.ERROR:
return {
Expand Down