Skip to content

Conversation

@ADITYATIWARI342005
Copy link

Proposed changes

This PR fixes the UI cutout issue for HTTP Probe properties input fields (Timeout, Interval, Attempt, etc.) in ChaosCenter by changing the inputGroup type from 'number' to 'string' to match the styling behavior of the Name field. This resolves the visual glitch that appears when these input fields are focused.

Issue Link: #5258

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

This is a minimal UI fix that changes 6 instances across 3 files. The validation logic remains unchanged as it's handled by Yup schemas, not input types. The fix ensures consistent focus styling across all HTTP Probe input fields.

…tGroup type from 'number' to 'string'

Signed-off-by: ADITYA TIWARI <142050150+ADITYATIWARI342005@users.noreply.github.com>
@ADITYATIWARI342005
Copy link
Author

Hi @PriteshKiri
this PR is ready for review.

@PriteshKiri
Copy link
Contributor

Hey @ADITYATIWARI342005

Could you please share a Screenshort or video for the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants