Skip to content

Conversation

@Calvinaud
Copy link
Contributor

Proposed changes

Remove hardcoded registry name when creating experiment from the UI #5197

  • Updated both updateExperimentManifestWithFaultData and addFaultsToManifest to use experiment ImageRegistry
  • Defaulting to litmuschaos if no ImageRestry find in experiment

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • [NA] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [NA] I have added necessary documentation (if appropriate)

- Replaced in both updateExperimentManifestWithFaultData and addFaultsToManifest
- Defaulting to litmuschaos if no ImageRestry find in experiment

Signed-off-by: Calvin Audier <calvin.audier@amadeus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant