-
Notifications
You must be signed in to change notification settings - Fork 3k
feat(realtime): reuse realtime session across agent handoffs if supported #5229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
9ea8cad
feat(realtime): reuse realtime session across agent handoffs if suppo…
longcw b4359bf
check tools before reuse
longcw e653c56
clean
longcw 975eccf
detach after _pause_scheduling_task
longcw fea72dd
fix test
longcw 1ecc2e9
clean up in exception
longcw cc1c8de
(taskgroups): set llm to NOT_GIVEN (#5301)
tinalenguyen 5b6c64e
improve error handle
longcw a8c61de
(realtimesession): add reset method (#5303)
tinalenguyen 26b529c
rename to update_session
longcw 816a035
Merge remote-tracking branch 'origin/main' into longc/reuse-rt-sessio…
longcw a9c20e9
fix RealtimeCapabilities
longcw 2b56c5e
Merge remote-tracking branch 'origin/main' into longc/reuse-rt-sessio…
longcw 365f649
Merge remote-tracking branch 'origin/main' into longc/reuse-rt-sessio…
longcw 33299e7
address comments
longcw 6f15356
clean _item_create_future and _item_delete_future when timeout
longcw a7ec954
fix taskgroup for realtime model
longcw da8d099
add test for reusing realtime session across agent handoffs
longcw c5a811b
print test output
longcw 4db843c
print error msg
longcw df4e7b5
update test_update_chat_ctx
longcw e8d391f
rename to _update_session
longcw 815e3ca
rename to mutable_
longcw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should find a better name for
per_response_tool_choiceThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
mutable_*:mutable_chat_context,mutable_instructions,mutable_tools, andmutable_tool_choice?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i second
mutable_*!