-
Notifications
You must be signed in to change notification settings - Fork 176
Sound API 2 #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Sound API 2 #943
Changes from all commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
3e48207
sp2
hiroshihorie 6e9cb19
modes
hiroshihorie d52174c
dst1
hiroshihorie 070a5fb
Merge branch 'main' into hiroshi/sound-player-2
hiroshihorie 1f0b191
organize tuple
hiroshihorie 2b86f39
port session requirement
hiroshihorie b187051
Merge remote-tracking branch 'origin/main' into hiroshi/sound-player-2
hiroshihorie 44cb48c
propagate
hiroshihorie 603d5f7
simplify
hiroshihorie 008cb87
fixes
hiroshihorie 439906f
fix 2
hiroshihorie 735c133
fix 3
hiroshihorie 798b970
ref 1
hiroshihorie cb0c4c3
stop destination
hiroshihorie a4c62cf
fixes
hiroshihorie aa08a44
read
hiroshihorie 53b68c5
fix ci
hiroshihorie 5a66b25
Merge branch 'main' into hiroshi/sound-player-2
hiroshihorie a994a6b
Merge branch 'main' into hiroshi/sound-player-2
hiroshihorie 05f4c29
Merge branch 'main' into hiroshi/sound-player-2
hiroshihorie ff883ef
remove noise
hiroshihorie ceff523
fix qos warning
hiroshihorie 57eb6e5
changes
hiroshihorie 21781e0
Serialize player node pool reuse
hiroshihorie 4098e53
Propagate render frame limits to sound players
hiroshihorie aaf8e81
actor
hiroshihorie c4cca0b
docs 1
hiroshihorie 50ead0c
node state
hiroshihorie 0ede69b
handle
hiroshihorie 7a655de
optimize
hiroshihorie 41b4598
refactor session requirement
hiroshihorie 49520ba
optionset
hiroshihorie 82c5251
Merge branch 'main' into hiroshi/sound-player-2
hiroshihorie ecb5194
fix ci 1
hiroshihorie 754931b
Document SoundPlayer usage and behavior
hiroshihorie e4fbb2b
Auto-release session requirement handles
hiroshihorie 6c063a1
Warn when remote sound playback is unavailable
hiroshihorie 10aa5b2
Isolate SoundPlayer with a global actor
hiroshihorie 7304166
Cache converted local sound buffers
hiroshihorie ae1a9c7
Rebuild SoundPlayer after engine config changes
hiroshihorie 9b7a3c9
Clarify remote sound warning reasons
hiroshihorie fadaad3
Align MixerEngineObserver state binding names
hiroshihorie 57c5ed9
Group SoundPlayer local engine state
hiroshihorie 4fe7a52
Extract SoundPlayer local reset helpers
hiroshihorie 060275f
Simplify AudioSessionEngineObserver config flow
hiroshihorie 568b9ae
format
hiroshihorie 3df0d71
Split SoundPlayer types from implementation
hiroshihorie 5f4a07e
Introduce SoundHandle named sound lookup
hiroshihorie bf5328d
Tighten SoundPlayer engine start helper
hiroshihorie 957dae4
Avoid restoring released sound state
hiroshihorie 8539c01
Use SoundPlayer error category
hiroshihorie 6b94dad
Document SoundHandle API surface
hiroshihorie 1ba4361
Rename sound playback options
hiroshihorie 97e44ba
Replace force-unwrapped AVAudioFormat with safe alternatives
hiroshihorie 20af8c6
Use reference type for PreparedSound to prevent stale copies across a…
hiroshihorie ffa27f3
format
hiroshihorie 121ae9f
changes
hiroshihorie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| minor type="added" "SoundPlayer API for prepared audio clips with local playback and best-effort remote playback" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably should be called on
deinit.