Draft
Conversation
After a full reconnect, the camera could switch to the wrong device and switchCameraPosition() would stop working. Two issues in CameraCapturer: 1. options.position was never updated after device selection via fallback, so reconnects re-ran fallback logic instead of re-selecting the same camera. 2. The position property returned .unspecified when device was nil (between stop/start), causing switchCameraPosition() to always fail after reconnect. Fix: persist the resolved device position in options after startCapture, and fall back to options.position instead of .unspecified when device is nil. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.