Skip to content

update proto: add agent_dev proto for CLI hot reload IPC#597

Open
theomonnom wants to merge 2 commits intomainfrom
theo/agent-dev-proto
Open

update proto: add agent_dev proto for CLI hot reload IPC#597
theomonnom wants to merge 2 commits intomainfrom
theo/agent-dev-proto

Conversation

@theomonnom
Copy link
Copy Markdown
Member

No description provided.

@theomonnom theomonnom requested review from a team and davidzhao April 5, 2026 04:12
@theomonnom theomonnom changed the title add agent_dev proto for CLI hot reload IPC update proto: add agent_dev proto for CLI hot reload IPC Apr 5, 2026
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 2 additional findings in Devin Review.

Open in Devin Review

@@ -0,0 +1,33 @@
# -*- coding: utf-8 -*-
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 New agent_dev module not exported from agent_pb/__init__.py

The new agent_dev module was added to the agent_pb package but livekit-protocol/livekit/protocol/agent_pb/__init__.py was not updated to import it. The existing __init__.py only contains from . import agent_session. This means livekit.protocol.agent_pb.agent_dev is not accessible after importing the package — confirmed by running hasattr(livekit.protocol.agent_pb, 'agent_dev') which returns False. This is inconsistent with the established pattern where agent_session is explicitly imported in __init__.py.

Prompt for agents
The file livekit-protocol/livekit/protocol/agent_pb/__init__.py currently only contains:

from . import agent_session

It needs to be updated to also import the new agent_dev module:

from . import agent_session
from . import agent_dev

This follows the existing pattern where all submodules in a package are imported in __init__.py so they are accessible as attributes of the package when imported.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants