clip: add more logging to debug failed clips #1318
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clips are failing reporting 'start time specified exceeds duration of manifest'. This may happen for webrtc streams where the clip request comes in but the segments and manifest hasn't been written yet to S3. I n this case, the start time would fall past the latest segment and this error case would be hit -- however, we have several retries for this exact scenario. Based on logs, there are 10 retries every 5 seconds in addition to 3 studio retries - this should be sufficient for the latest segments to be written to S3 and the clip request would eventually succeed. This is not happening so we're adding the additional logging to ensure latest manifests are being downloaded on retry attempts.
emranemran
force-pushed
the
emran/add-logging-to-debug-clip
branch
from
8204cc3 to
5169c4e
Compare
mjh1
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clips are failing reporting 'start time specified exceeds duration of manifest'. This may happen for webrtc streams where the clip request comes in but the segments and manifest hasn't been written yet to S3. I n this case, the start time would fall past the latest segment and this error case would be hit -- however, we have several retries for this exact scenario.
Based on logs, there are 10 retries every 5 seconds in addition to 3 studio retries - this should be sufficient for the latest segments to be written to S3 and the clip request would eventually succeed. This is not happening so we're adding the additional logging to ensure latest manifests are being downloaded on retry attempts.