fix: hide performance regions with no data #359
+53
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Previously all data returned by the testers was displayed. This commmit changes the behavoir to only display data of regions and pipelines for which the tester did have data.
rickstaa
force-pushed
the
fix/hide-no-performance-data-regions
branch
from
83da5c7 to
730ea27
Compare
Member
Author
|
@ECWireless Since discussions about changing the data endpoint haven’t resulted in an update yet, we could merge this logic into the codebase as a temporary patch, with a clear comment noting that the endpoint still needs to be updated. This would allow us to improve the usability of the performance leaderboard in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all data returned by the testers was displayed. This pull request changes the behavoir to only display data of regions and pipelines for which the tester did have data.