Adds smart selection of correct input channel for multi-channel mic #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Streaming did not work on macOS with a multi-channel mic.
Problem
macOS
Streaming did not work on macOS with a multi-channel mic.
Solution
Patch
record_macos/macos/record_macos/Sources/record_macos/delegate/RecorderStreamDelegate.swiftto automatically select the channel with most variable amplitude.Testing
Tested on:
Modified Files
macOS
record_macos/macos/record_macos/Sources/record_macos/delegate/RecorderStreamDelegate.swiftBreaking Changes
None that I encountered but
updateAmplitudeInt16is nowupdateAmplitudeFloat.