-
Notifications
You must be signed in to change notification settings - Fork 32
Updates MFEMReader and winding number example #1760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arlie-Capps
reviewed
Jan 6, 2026
jcs15c
reviewed
Jan 6, 2026
Arlie-Capps
reviewed
Jan 6, 2026
Arlie-Capps
approved these changes
Jan 6, 2026
Contributor
Arlie-Capps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Kenny!
jcs15c
approved these changes
Jan 7, 2026
Contributor
jcs15c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the updates!
84d5bfb to
382a7af
Compare
Cleans up the sidre mcarray example a bit.
Internal refactoring: Use a unique_ptr internally within the MFEMReader.
…ization (On by default)
Also adds a unit test for this.
…inalize if we initialized it
This makes it easy to have SLIC_ASSERT and SLIC_ERROR throw an exception instead of aborting and can be especially helpful when testing that assertions/errors happen as expected.
Attributes in file are often not contiguous, so we cannot write them to the array position of their index. Instead, we'll add them in order and return a corresponding array of original attributes when desired.
And adds tests for this.
382a7af to
26dc2a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
Core
Issues related to Axom's 'core' component
maintenance
Issues related to code maintenance
Quest
Issues related to Axom's 'quest' component
Slic
Issues related to Axom's 'slic' component
Testing
Issues related to testing Axom
usability
Related to code usability
User Request
Issues related to user requests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a few improvements centered around improvements to the quest winding number example
MFEMReaderInstead, we add an optional array to map the returned curves to their attributes.
svg2contoursscript which convets an SVG to an mfem Mesh fileviewBoxinfo, followed byheightandwidthuvinstead ofvenvslic::getAbortFunction()to return the function pointer associated with the slic error handlerSLIC_ERROR/SLIC_ASSERTcalls happen without gtest Death tests (which cannot run in MPI-based tests).MPIWrappernow only finalizes MPI if it initialized it