Parquet: add mode to find system-wide arrow parquet >= v19.#409
Merged
steiltre merged 1 commit intollnl:v0.10-devfrom Mar 20, 2026
Merged
Conversation
KIwabuchi
changed the title
KIwabuchi
changed the title
KIwabuchi
force-pushed
the
feature/parquet-use-system-install
branch
from
4a4193f to
787d728
Compare
steiltre
reviewed
Mar 20, 2026
| include(FindArrowParquet) | ||
| if (YGM_FIND_PARQUET_IN_SYSTEM) | ||
| if (YGM_INSTALL_PARQUET) | ||
| message(INFO "Both YGM_FIND_PARQUET_IN_SYSTEM and YGM_INSTALL_PARQUET are also ON. System-wide Arrow Parquet is used, if found.") |
Collaborator
There was a problem hiding this comment.
Has the behavior in this message been tested? Looking at the find_arrow_parquet_config and install_arrow_parquet functions, it looks like setting both of these would lead to an error here when CMake tries adding the arrow_shared target that should already be found as part of the system Arrow.
Collaborator
There was a problem hiding this comment.
Just tested this on my laptop, and it works as advertised.
Member
Author
|
@steiltre Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.