This repository was archived by the owner on Dec 14, 2022. It is now read-only.
fix(admin-firestore): add types from @google-cloud/firestore #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing an app using firebase-admin with
admin.firestore()instead offirebase.firestore():getting:
error TS2345: Argument of type 'FirebaseFirestore.Firestore' is not assignable to parameter of type 'firebase.firestore.Firestore'.@timestamp()and@geopoint()fields :TypeError: Cannot read property 'Timestamp' of undefinedI guess that happens because different types are imported by non-admin and admin SDKs:
from
firebase/index.d.tsand@google-cloud/firestore/types/firestore.d.tsrespectively.Fixed that for TimeStamps and GeoPoints using combined types/fallback refs, and also types in firestorm.initialize()