Fix: Missing update hook for lgms_modules_disabled field on existing installs#571
Open
sinhaparth5 wants to merge 1 commit intolocalgovdrupal:4.xfrom
Open
Fix: Missing update hook for lgms_modules_disabled field on existing installs#571sinhaparth5 wants to merge 1 commit intolocalgovdrupal:4.xfrom
sinhaparth5 wants to merge 1 commit intolocalgovdrupal:4.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The field lgms_modules_disabled was introduced to the localgov_microsites_group module (found in config/install), but there is no corresponding update hook to create this field for sites that were installed prior to its introduction.
Currently, code in
ContentTypeHelper::moduleEnable()assumes this field exists. On older installations, this leads to fatal errors or warnings because the Entity API cannot find the field definition in the active configuration, even if the column has been manually added to the database.Proposed Resolution
Add an update hook (10002) to
localgov_microsites_group.installthat:Checks if field.storage.group.lgms_modules_disabled exists.
Checks if field.field.group.microsite.lgms_modules_disabled exists.
Creates them programmatically if they are missing to bring the site schema in line with the module's config/install definitions.