Delete action for a Service Landing page or Service Sub Landing Page can trigger a PHP error.#329
Merged
finnlewis merged 1 commit intolocalgovdrupal:2.xfrom Nov 18, 2025
Conversation
marcopagliarulo
changed the title
Contributor
|
@localgovdrupal/maintainers how do I re-run the tests here. This issue fixes a quite major bug (can't delete landing and sub landing pages). |
andybroomfield
approved these changes
Nov 14, 2025
Contributor
andybroomfield
left a comment
andybroomfield
left a comment
There was a problem hiding this comment.
Thanks @marcopagliarulo.
I've tested this and pages can now be deleted with modal.
I don't think we need a separate test for deleting pages as that's standard Drupal unless we feel that's something we can benefit from, but we need to re-run the tests on this PR before merging.
andybroomfield
force-pushed
the
fix/2.x-328-delete-action-can-trigger-php-error
branch
from
01f2220 to
25a1e38
Compare
Contributor
|
@localgovdrupal/maintainers I added a commit and force pushed a reset. That gave me the button to approve the workflow to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
The PR fix the definition of
They must be array of string, not string.
How to test
How can we measure success?
The error message "Oops, something went wrong. Check your browser's developer console for more details." Is not shown and the confirmation dialog is shown.
Have we considered potential risks?
No risks, it's a simple coding issue.
Related Issue
#328