Skip to content

Use output.Sink in stop command#74

Closed
carole-lavillonniere wants to merge 1 commit intomainfrom
emit-stop
Closed

Use output.Sink in stop command#74
carole-lavillonniere wants to merge 1 commit intomainfrom
emit-stop

Conversation

@carole-lavillonniere
Copy link
Collaborator

@carole-lavillonniere carole-lavillonniere commented Mar 4, 2026

Replaces the onProgress func(string) callback in container.Stop with an output.Sink, consistent with the pattern used in container.Start and the rest of the codebase

image

@carole-lavillonniere carole-lavillonniere changed the title Use output.Sink in container.Stop instead of callback Use output.Sink in container.Stop Mar 4, 2026
@carole-lavillonniere carole-lavillonniere changed the title Use output.Sink in container.Stop Use output.Sink in stop command Mar 4, 2026
@carole-lavillonniere carole-lavillonniere marked this pull request as ready for review March 4, 2026 08:20
@coderabbitai
Copy link

coderabbitai bot commented Mar 4, 2026

Warning

Rate limit exceeded

@carole-lavillonniere has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minutes and 30 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 8fd19554-d06a-49be-be3b-0d935601ec1e

📥 Commits

Reviewing files that changed from the base of the PR and between d5c49f6 and ac4540a.

📒 Files selected for processing (3)
  • cmd/stop.go
  • internal/container/stop.go
  • test/integration/stop_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch emit-stop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@carole-lavillonniere
Copy link
Collaborator Author

Closing since @gtsiolis did the same work here #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant