ec2: Fix Fleet on-demand instance provisioning#121
Merged
nik-localstack merged 1 commit intolocalstack:localstackfrom Mar 2, 2026
Merged
ec2: Fix Fleet on-demand instance provisioning#121nik-localstack merged 1 commit intolocalstack:localstackfrom
nik-localstack merged 1 commit intolocalstack:localstackfrom
Conversation
nik-localstack
commented
Feb 26, 2026
| target_capacity_specification.get( | ||
| "OnDemandTargetCapacity", self.target_capacity | ||
| ) | ||
| target_capacity_specification.get("OnDemandTargetCapacity", 0) |
Author
There was a problem hiding this comment.
Any remaining capacity is handled in line 140
viren-nadkarni
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EC2 Fleet was not launching the correct number of on-demand instances in two scenarios:
OnDemandTargetCapacitywas greater than 1, only a single instance was launched instead of the requested amount.OnDemandTargetCapacitywas omitted from the request, the remaining capacity fallback did not behave correctly.