Skip to content

install-jar: avoid silent swallowing of curl download failure #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soxofaan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

install-jar: avoid silent swallowing of curl download failure #710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions geopyspark/command/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import os
from os import path
import argparse
import subprocess

from geopyspark.geopyspark_constants import JAR, CWD

Expand All @@ -31,12 +32,14 @@ def write_jar_path(jar_path):
f.write(jar_path)

def download_jar(jar_path):
import subprocess

jar_location = path.join(jar_path, JAR)
write_jar_path(jar_location)

subprocess.call(['curl', '-L', JAR_URL, '-o', jar_location])
print("Downloading", JAR_URL)
# Will raise exception when curl download fails (e.g. 404 not found)
subprocess.check_call(['curl', '-L', '--fail', JAR_URL, '-o', jar_location])
print("Downloaded to", jar_location)

write_jar_path(jar_location)

def get_jar_path():
default_jar_location = path.join(DEFAULT_JAR_PATH, JAR)
Expand Down