Skip to content

Conversation

@flomedja
Copy link
Contributor

@flomedja flomedja commented Jan 5, 2026

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)

The MR ensure that the spec.resources for a pod is only synced on the host cluster when supported. It is supported in beta starting version 1.34.0
resolves #ENG-8682

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...

What else do we need to know?


Note

Adds host-version awareness to pod translation to avoid using unsupported pod-level resources on older clusters.

  • Fetches and stores host ServerVersion in translator and during Translate drops pPod.Spec.Resources when host < v1.34.0
  • Updates imports/structs to include util/version and version.Info
  • Adds TestPodResourcesTranslation covering versions above/below 1.34 and configures fake discovery client in test utilities

Written by Cursor Bugbot for commit e2cfecf. This will update automatically on new commits. Configure here.

@flomedja flomedja requested review from a team and FabianKramm as code owners January 5, 2026 18:54
@flomedja flomedja force-pushed the eng8682-allow-pod-level-resources branch from 4f5c5d7 to 5c73d72 Compare January 5, 2026 19:18
@flomedja flomedja marked this pull request as draft January 5, 2026 19:20
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@flomedja flomedja force-pushed the eng8682-allow-pod-level-resources branch from 5c73d72 to e2cfecf Compare January 5, 2026 19:38
@flomedja flomedja marked this pull request as ready for review January 5, 2026 20:11
@FabianKramm FabianKramm merged commit 8e7b1d5 into loft-sh:main Jan 9, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants