Skip to content

Conversation

@dmitry-goncharuk
Copy link

Logdna::Ruby logger overrides its parent Logger class behavior for helper methods such as #info?.
It also defines a 5th level TRACE that seems to be the same as Loger::Severity::UNKNOWN.

So I've decided to rewrite the overridden methods because it makes Logdna::Ruby logger incompatible with, for example, Rails. For example ActionController::LogSubscriber https://github.com/rails/rails/blob/v5.2.1/actionpack/lib/action_controller/log_subscriber.rb#L8 is only logging responses when severity is set to below INFO. But the Logdna::Ruby#info? returns false even if the log level has been set to DEBUG.

@dmitry-goncharuk dmitry-goncharuk force-pushed the improvement/v1.5.0/log-level branch from d4ab9fc to 01c508d Compare September 7, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants