Update lua-guidelines.md #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ПП |
ek-kharitonova
suggested changes
Jan 15, 2018
| Линейные коллекции (в смысле `ipairs`) допускается называть с суффиксом _list в | ||
| случаях, когда нужно особо подчеркнуть линейность. | ||
|
|
||
| Имя булевой переменной, обычно, is_* (are_*, has_* и проч. формы to be), have_*, |
There was a problem hiding this comment.
часть слов в этой строке на гитлабе отображается курсивом. По разметке - не понимаю, почему, но наверное стоит разобраться
There was a problem hiding this comment.
возможно, их здесь вообще лучше выделить в ` ?
| ##Циклы | ||
| ## Циклы | ||
|
|
||
| * Запрещается использовать `ipairs()`. Вместо него — numeric for. |
Author
There was a problem hiding this comment.
"numeric for" это же вроде термин, а не название команды. Поэтому и не выделил его.
| ## Циклы | ||
|
|
||
| * Запрещается использовать `ipairs()`. Вместо него — numeric for. | ||
|
|
There was a problem hiding this comment.
в строках 499 и далее, где начинается
с 1. Мотивация: идиома языка, в Lua считают с 1. - я бы выделила единицы и нули. а то нули на нуди не похожи
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.