Skip to content

Add Hisource HI-K0402WS pictures#88

Merged
logicog merged 1 commit intologicog:mainfrom
TylerDurden-23:main
Feb 6, 2026
Merged

Add Hisource HI-K0402WS pictures#88
logicog merged 1 commit intologicog:mainfrom
TylerDurden-23:main

Conversation

@TylerDurden-23
Copy link
Collaborator

No description provided.

@vDorst
Copy link
Collaborator

vDorst commented Jan 21, 2026

Thanks for the pictures.
Would you also make a device documentation wiki like https://github.com/logicog/RTLPlayground/blob/main/doc/devices/SWTG024AS.md
Document the finding that we currently have.
Please remove the machine.h from the commit.

@TylerDurden-23
Copy link
Collaborator Author

Removed.
I will try to add the documentation - I try to get at least the SFP ports working first.

@logicog logicog requested a review from vDorst January 24, 2026 08:56
@logicog logicog self-assigned this Jan 24, 2026
Copy link
Owner

@logicog logicog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work, one can see all the additional work behind the scenes that was necessary!

config.txt Outdated
ip 192.168.10.247
gw 192.168.10.1
ip 192.168.4.247
gw 192.168.4.10
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take this out again, as it is not specific to this device.

debug.h Outdated
@@ -1,6 +1,9 @@
#define DEBUG
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take this out again, as it is not specific to this device.

machine.h Outdated
* Select your machine type below
*/
#define MACHINE_KP_9000_6XHML_X2
// #define MACHINE_KP_9000_6XHML_X2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change machine.h to merely add the define for the K0402WS, commented out? Otherwise it will be affecting the default. We will need a different solution than having the machine selected defined in machine.h, that is now clear. Possibly a define on the make command line. Maybe you have an idea?

@TylerDurden-23
Copy link
Collaborator Author

Sorry - it wasn't clear that these additional commit were added to this PR. This PR should only contain the pictures - all else is cleanly contained in #97 ... with all the issues already resolved.

@logicog
Copy link
Owner

logicog commented Jan 25, 2026

You can use git rebase -i HEAD~10 (10 is just a guess, maybe more is needed, less is probably also OK) to drop commits, then use git push -f origin <your_branch> to update the PR.

@TylerDurden-23
Copy link
Collaborator Author

@logicog fixed it - what a horrible tool.

@TylerDurden-23 TylerDurden-23 force-pushed the main branch 2 times, most recently from a13aa3a to a528436 Compare January 27, 2026 14:56
@logicog
Copy link
Owner

logicog commented Feb 6, 2026

Thanks a lot for the contribution!

@logicog logicog merged commit ee190a8 into logicog:main Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants